| Message ID | 1472714638-15676-2-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote: > Hard-coded pinctrl configuration values are scattered through DTS files. > The numbers are difficult to decode by human, especially without the > datasheet. Additionally the drive strength differs between Exynos SoC > families increasing the confusion. > > The header will help making this more readable and maintainable. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > MAINTAINERS | 1 + > include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > create mode 100644 include/dt-bindings/pinctrl/samsung.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8e81b1dde30..836bcd327ee4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) > S: Maintained > F: drivers/pinctrl/samsung/ > +F: include/dt-bindings/pinctrl/samsung.h > > PIN CONTROLLER - SINGLE > M: Tony Lindgren <tony@atomide.com> > diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h > new file mode 100644 > index 000000000000..0f410ba5ec7e > --- /dev/null > +++ b/include/dt-bindings/pinctrl/samsung.h > @@ -0,0 +1,57 @@ > +/* > + * Samsung's Exynos pinctrl bindings > + * > + * Copyright (c) 2016 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * Author: Krzysztof Kozlowski <krzk@kernel.org> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__ > +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__ Minor nit: shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file is named samsung.h and is going to be used also by s3c* SoCs)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/01/2016 01:02 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote: >> Hard-coded pinctrl configuration values are scattered through DTS files. >> The numbers are difficult to decode by human, especially without the >> datasheet. Additionally the drive strength differs between Exynos SoC >> families increasing the confusion. >> >> The header will help making this more readable and maintainable. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- >> MAINTAINERS | 1 + >> include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 58 insertions(+) >> create mode 100644 include/dt-bindings/pinctrl/samsung.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d8e81b1dde30..836bcd327ee4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) >> S: Maintained >> F: drivers/pinctrl/samsung/ >> +F: include/dt-bindings/pinctrl/samsung.h >> >> PIN CONTROLLER - SINGLE >> M: Tony Lindgren <tony@atomide.com> >> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h >> new file mode 100644 >> index 000000000000..0f410ba5ec7e >> --- /dev/null >> +++ b/include/dt-bindings/pinctrl/samsung.h >> @@ -0,0 +1,57 @@ >> +/* >> + * Samsung's Exynos pinctrl bindings >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * Author: Krzysztof Kozlowski <krzk@kernel.org> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__ >> +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__ > > Minor nit: > > shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file > is named samsung.h and is going to be used also by s3c* SoCs)? Yes, it should. Thanks! Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/MAINTAINERS b/MAINTAINERS index d8e81b1dde30..836bcd327ee4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) S: Maintained F: drivers/pinctrl/samsung/ +F: include/dt-bindings/pinctrl/samsung.h PIN CONTROLLER - SINGLE M: Tony Lindgren <tony@atomide.com> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h new file mode 100644 index 000000000000..0f410ba5ec7e --- /dev/null +++ b/include/dt-bindings/pinctrl/samsung.h @@ -0,0 +1,57 @@ +/* + * Samsung's Exynos pinctrl bindings + * + * Copyright (c) 2016 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * Author: Krzysztof Kozlowski <krzk@kernel.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__ +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__ + +#define EXYNOS_PIN_PULL_NONE 0 +#define EXYNOS_PIN_PULL_DOWN 1 +#define EXYNOS_PIN_PULL_UP 3 + +/* Pin function in power down mode */ +#define EXYNOS_PIN_PDN_OUT0 0 +#define EXYNOS_PIN_PDN_OUT1 1 +#define EXYNOS_PIN_PDN_INPUT 2 +#define EXYNOS_PIN_PDN_PREV 3 + +/* Drive strengths for Exynos3250, Exynos4 (all) and Exynos5250 */ +#define EXYNOS4_PIN_DRV_LV1 0 +#define EXYNOS4_PIN_DRV_LV2 2 +#define EXYNOS4_PIN_DRV_LV3 1 +#define EXYNOS4_PIN_DRV_LV4 3 + +/* Drive strengths for Exynos5260 */ +#define EXYNOS5260_PIN_DRV_LV1 0 +#define EXYNOS5260_PIN_DRV_LV2 1 +#define EXYNOS5260_PIN_DRV_LV4 2 +#define EXYNOS5260_PIN_DRV_LV6 3 + +/* Drive strengths for Exynos5410, Exynos542x and Exynos5800 */ +#define EXYNOS5420_PIN_DRV_LV1 0 +#define EXYNOS5420_PIN_DRV_LV2 1 +#define EXYNOS5420_PIN_DRV_LV3 2 +#define EXYNOS5420_PIN_DRV_LV4 3 + +#define EXYONS_PIN_PDN_OUT0 0 +#define EXYNOS_PIN_PDN_OUT1 1 +#define EXYNOS_PIN_PDN_INPUT 2 +#define EXYNOS_PIN_PDN_PREV 3 + +#define EXYNOS_PIN_FUNC_INPUT 0 +#define EXYNOS_PIN_FUNC_OUTPUT 1 +#define EXYNOS_PIN_FUNC_2 2 +#define EXYNOS_PIN_FUNC_3 3 +#define EXYNOS_PIN_FUNC_4 4 +#define EXYNOS_PIN_FUNC_5 5 +#define EXYNOS_PIN_FUNC_F 0xf + +#endif /* __DT_BINDINGS_PINCTRL_EXYNOS_H__ */
Hard-coded pinctrl configuration values are scattered through DTS files. The numbers are difficult to decode by human, especially without the datasheet. Additionally the drive strength differs between Exynos SoC families increasing the confusion. The header will help making this more readable and maintainable. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- MAINTAINERS | 1 + include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) create mode 100644 include/dt-bindings/pinctrl/samsung.h