From patchwork Thu Sep 1 09:21:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 9308647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E6D2607D2 for ; Thu, 1 Sep 2016 09:22:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DE86292BA for ; Thu, 1 Sep 2016 09:22:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 523D2292C0; Thu, 1 Sep 2016 09:22:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DFD6292BA for ; Thu, 1 Sep 2016 09:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753659AbcIAJWQ (ORCPT ); Thu, 1 Sep 2016 05:22:16 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:26665 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcIAJWN (ORCPT ); Thu, 1 Sep 2016 05:22:13 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OCT004RHJCUY250@mailout1.w1.samsung.com>; Thu, 01 Sep 2016 10:22:06 +0100 (BST) X-AuditID: cbfec7f4-f79cb6d000001359-61-57c7f33d7a47 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 73.8E.04953.D33F7C75; Thu, 1 Sep 2016 10:22:06 +0100 (BST) Received: from AMDC2174.DIGITAL.local ([106.120.53.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OCT00K8IJCMUB30@eusync2.samsung.com>; Thu, 01 Sep 2016 10:22:05 +0100 (BST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim Cc: Arnd Bergmann , javier@osg.samsung.com, Linus Walleij , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Date: Thu, 01 Sep 2016 11:21:54 +0200 Message-id: <1472721715-2833-6-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com> References: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xK7p2n4+HG2y0t/g76Ri7xcYZ61kt 5h85x2rx5u0aJovXLwwt+h+/ZrY4f34Du8WUP8uZLDY9vsZqcXnXHDaLGef3MVksvX6RyaJ1 7xF2i8Nv2lktVu36w+jA77Fm3hpGj9+/JjF67Jx1l91j06pONo871/aweWxeUu+xpR8o1Ldl FaPH501yAZxRXDYpqTmZZalF+nYJXBnvpoYWrJKu+LG+i62B8bZoFyMnh4SAicSReefYIWwx iQv31rN1MXJxCAksZZRo2XaLHcJpZJKY++YeG0gVm4CxxOblS8CqRATeMEn8a93ACOIwC5xj lHhy+QlYlbCAj8SVi3fBbBYBVYmZ+04zgti8Am4S77ofM0Psk5M4eWwyK4jNKeAu8ftXK1iN EFDNtsf72Ccw8i5gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERLKX3YwLj5mdYhRgINR iYfX4c2xcCHWxLLiytxDjBIczEoivPs/HQ8X4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQ IYH0xJLU7NTUgtQimCwTB6dUA6N7cjj/qv3tGd+UTswRfNJnkeW5dVP66hP8pppf9e8yvrp1 upDZ0krg4/y8Q7rPOlhS/Bpv7JgnMW+HsOQ3hkeMUV1d2jUJFZfr1TpimedmyafbzBfIfLA0 ot/W6rp3ro7EIb7ZxiHl/5+fuP+F787lV3tlfte8P1AmtVRTfnpUnQBrxPX440osxRmJhlrM RcWJAOq37NVhAgAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi index 527e3193817f..6274359fb323 100644 --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include + &pinctrl_0 { /* * Pin banks @@ -83,91 +85,91 @@ uart0_data: uart0-data { samsung,pins = "gph-0", "gph-1"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart0_fctl: uart0-fctl { samsung,pins = "gph-8", "gph-9"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart1_data: uart1-data { samsung,pins = "gph-2", "gph-3"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart1_fctl: uart1-fctl { samsung,pins = "gph-10", "gph-11"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart2_data: uart2-data { samsung,pins = "gph-4", "gph-5"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart2_fctl: uart2-fctl { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; uart3_data: uart3-data { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; extuart_clk: extuart-clk { samsung,pins = "gph-12"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; i2c0_bus: i2c0-bus { samsung,pins = "gpe-14", "gpe-15"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; spi0_bus: spi0-bus { samsung,pins = "gpe-11", "gpe-12", "gpe-13"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd0_clk: sd0-clk { samsung,pins = "gpe-5"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd0_cmd: sd0-cmd { samsung,pins = "gpe-6"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd0_bus1: sd0-bus1 { samsung,pins = "gpe-7"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd0_bus4: sd0-bus4 { samsung,pins = "gpe-8", "gpe-9", "gpe-10"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd1_cmd: sd1-cmd { samsung,pins = "gpl-8"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd1_clk: sd1-clk { samsung,pins = "gpl-9"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd1_bus1: sd1-bus1 { samsung,pins = "gpl-0"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; sd1_bus4: sd1-bus4 { samsung,pins = "gpl-1", "gpl-2", "gpl-3"; - samsung,pin-function = <2>; + samsung,pin-function = ; }; };