| Message ID | 1478748643-3081-1-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Alim, On 10/11/16 03:30, Alim Akhtar wrote: > This patch adds ARM Performance Monitor Unit dt node for exynos7. > PMU provides various statistics on the operation of the CPU and > memory system at runtime, which are very useful when debugging or > profiling code. This enables the same. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi > index e0d0d01..53ce4be 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -472,6 +472,14 @@ > status = "disabled"; > }; > > + arm-pmu { > + compatible = "arm,cortex-a57-pmu", "arm,armv8-pmuv3"; > + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; Per Documentation/devicetree/bindings/arm/pmu.txt there should also be an "interrupt-affinity" property describing which SPI belongs to which core. Robin. > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = <GIC_PPI 13 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Robin, On 11/10/2016 07:07 PM, Robin Murphy wrote: > Hi Alim, > > On 10/11/16 03:30, Alim Akhtar wrote: >> This patch adds ARM Performance Monitor Unit dt node for exynos7. >> PMU provides various statistics on the operation of the CPU and >> memory system at runtime, which are very useful when debugging or >> profiling code. This enables the same. >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> index e0d0d01..53ce4be 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> @@ -472,6 +472,14 @@ >> status = "disabled"; >> }; >> >> + arm-pmu { >> + compatible = "arm,cortex-a57-pmu", "arm,armv8-pmuv3"; >> + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; > > Per Documentation/devicetree/bindings/arm/pmu.txt there should also be > an "interrupt-affinity" property describing which SPI belongs to which core. > Thanks for review, will resend after adding "interrupt-affinity" property. > Robin. > >> + }; >> + >> timer { >> compatible = "arm,armv8-timer"; >> interrupts = <GIC_PPI 13 >> > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index e0d0d01..53ce4be 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -472,6 +472,14 @@ status = "disabled"; }; + arm-pmu { + compatible = "arm,cortex-a57-pmu", "arm,armv8-pmuv3"; + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; + }; + timer { compatible = "arm,armv8-timer"; interrupts = <GIC_PPI 13
This patch adds ARM Performance Monitor Unit dt node for exynos7. PMU provides various statistics on the operation of the CPU and memory system at runtime, which are very useful when debugging or profiling code. This enables the same. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)