| Message ID | 1482299071-22637-1-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Pankaj, On 2016-12-21 06:44, Pankaj Dubey wrote: > From: Smitha T Murthy <smitha.t@samsung.com> > > For some IPs, there may be virtual child devices created and for them its > necessary to set the dma_ops if it's using reserved memory else it will call > the dummy dma_ops during buffer operations for the child devices which will > lead to memory mapping failure. > > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/of/of_reserved_mem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 366d8c3..d507c35 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -354,6 +354,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, > mutex_lock(&of_rmem_assigned_device_mutex); > list_add(&rd->list, &of_rmem_assigned_device_list); > mutex_unlock(&of_rmem_assigned_device_mutex); > + /* ensure that dma_ops is set for virtual devices > + * using reserved memory > + */ > + of_dma_configure(dev, np); > > dev_info(dev, "assigned reserved memory node %s\n", rmem->name); > } else { Best regards
On Wed, Dec 21, 2016 at 11:14:31AM +0530, Pankaj Dubey wrote: > From: Smitha T Murthy <smitha.t@samsung.com> > > For some IPs, there may be virtual child devices created and for them its > necessary to set the dma_ops if it's using reserved memory else it will call > the dummy dma_ops during buffer operations for the child devices which will > lead to memory mapping failure. > > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > drivers/of/of_reserved_mem.c | 4 ++++ > 1 file changed, 4 insertions(+) Applied, thanks. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 366d8c3..d507c35 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -354,6 +354,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, mutex_lock(&of_rmem_assigned_device_mutex); list_add(&rd->list, &of_rmem_assigned_device_list); mutex_unlock(&of_rmem_assigned_device_mutex); + /* ensure that dma_ops is set for virtual devices + * using reserved memory + */ + of_dma_configure(dev, np); dev_info(dev, "assigned reserved memory node %s\n", rmem->name); } else {