| Message ID | 1483958437-6572-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, On 2017년 01월 09일 19:40, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > > Regards > Andrzej > > v2: > - replaced magic numbers with macros, > - removed power domains, > - removed 0x prefixes from node names > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 68f764e..5552f77 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -814,6 +814,29 @@ > }; > }; > > + decon_tv: decon@13880000 { The 'decon_tv' node better to be located under the 'decon' node because of base address ordering. (decon@13800000, decon_tv@13880000) > + compatible = "samsung,exynos5433-decon-tv"; > + reg = <0x13880000 0x20b8>; > + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_XIU_TV0X>, > + <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, > + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; > + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", > + "aclk_xiu_decon0x", "pclk_smmu_decon0x", > + "sclk_decon_vclk", "sclk_decon_eclk"; > + samsung,disp-sysreg = <&syscon_disp>; > + interrupt-names = "fifo", "vsync", "lcd_sys"; > + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; > + iommu-names = "m0", "m1"; > + }; > + [snip] Except for ordering of 'decon_tv' node, looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Also, I tested these patches on TM2 board with Hoegeun Kwon (hoeguen.kwon@samsung.com). It is well working.
Hi Andrzej, Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Hoegeun On 01/09/2017 07:40 PM, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > > Regards > Andrzej > > v2: > - replaced magic numbers with macros, > - removed power domains, > - removed 0x prefixes from node names > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 68f764e..5552f77 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -814,6 +814,29 @@ > }; > }; > > + decon_tv: decon@13880000 { > + compatible = "samsung,exynos5433-decon-tv"; > + reg = <0x13880000 0x20b8>; > + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_XIU_TV0X>, > + <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, > + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; > + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", > + "aclk_xiu_decon0x", "pclk_smmu_decon0x", > + "sclk_decon_vclk", "sclk_decon_eclk"; > + samsung,disp-sysreg = <&syscon_disp>; > + interrupt-names = "fifo", "vsync", "lcd_sys"; > + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; > + iommu-names = "m0", "m1"; > + }; > + > syscon_disp: syscon@13b80000 { > compatible = "syscon"; > reg = <0x13b80000 0x1010>; > @@ -912,6 +935,26 @@ > #iommu-cells = <0>; > }; > > + sysmmu_tv0x: sysmmu@13a20000 { > + compatible = "samsung,exynos-sysmmu"; > + reg = <0x13a20000 0x1000>; > + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; > + clock-names = "pclk", "aclk"; > + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>; > + #iommu-cells = <0>; > + }; > + > + sysmmu_tv1x: sysmmu@13a30000 { > + compatible = "samsung,exynos-sysmmu"; > + reg = <0x13a30000 0x1000>; > + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>; > + clock-names = "pclk", "aclk"; > + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, > + <&cmu_disp CLK_ACLK_SMMU_TV1X>; > + #iommu-cells = <0>; > + }; > + > sysmmu_gscl0: sysmmu@0x13C80000 { > compatible = "samsung,exynos-sysmmu"; > reg = <0x13C80000 0x1000>; -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrzej, On Mon, Jan 09, 2017 at 11:40:35AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. All the three patches look good to me and they all apply on Krzysztof's branch and next branch. If you want you can add my review tag on all of them. Andi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 68f764e..5552f77 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -814,6 +814,29 @@ }; }; + decon_tv: decon@13880000 { + compatible = "samsung,exynos5433-decon-tv"; + reg = <0x13880000 0x20b8>; + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, + <&cmu_disp CLK_ACLK_DECON_TV>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_XIU_TV0X>, + <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", + "aclk_xiu_decon0x", "pclk_smmu_decon0x", + "sclk_decon_vclk", "sclk_decon_eclk"; + samsung,disp-sysreg = <&syscon_disp>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; + iommu-names = "m0", "m1"; + }; + syscon_disp: syscon@13b80000 { compatible = "syscon"; reg = <0x13b80000 0x1010>; @@ -912,6 +935,26 @@ #iommu-cells = <0>; }; + sysmmu_tv0x: sysmmu@13a20000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a20000 0x1000>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>; + #iommu-cells = <0>; + }; + + sysmmu_tv1x: sysmmu@13a30000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a30000 0x1000>; + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, + <&cmu_disp CLK_ACLK_SMMU_TV1X>; + #iommu-cells = <0>; + }; + sysmmu_gscl0: sysmmu@0x13C80000 { compatible = "samsung,exynos-sysmmu"; reg = <0x13C80000 0x1000>;