From patchwork Fri Oct 6 04:36:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 9988341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5093E6029B for ; Fri, 6 Oct 2017 04:37:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40D3C28D5E for ; Fri, 6 Oct 2017 04:37:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 32F3428D68; Fri, 6 Oct 2017 04:37:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D48D728D5E for ; Fri, 6 Oct 2017 04:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbdJFEgx (ORCPT ); Fri, 6 Oct 2017 00:36:53 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:38193 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdJFEgt (ORCPT ); Fri, 6 Oct 2017 00:36:49 -0400 Received: by mail-pg0-f68.google.com with SMTP id j3so1591945pga.5; Thu, 05 Oct 2017 21:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pGJ1AQ1TZ2QaEOW0XikBS7gXVwAJw8WW1gkbKBk7SMA=; b=sHZjE6RQVpTT41fLfp3lMsfl7t1p9wzWj/1BpEy2xJ/XfqRJGpFujmnwvoMYq4+nyA MADFUt3cYWSj70nhP2lM0SBsjTyNRDo3kZ1JifVY6HFPUU1c9F8+Mnl2gn15dolxw8n/ BQa32zEbm04dOLvLH3bQOI3UuEvigjzCesnz/kHkY7bp1OHKkIjmNy85i2HTWWCiV7H7 Ph45RdT5LqA1aso2dpF26zNrimXXOFHON3FrslIV6l0ReqM58Ycuz66qWbN/R7eeDIu+ soPKnUx6HqwLn8hh8Ebqlqyyn43PePjN9fHi8vhv1HgT73rzhQVB5VR9Bx14BnBaAdLr aEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pGJ1AQ1TZ2QaEOW0XikBS7gXVwAJw8WW1gkbKBk7SMA=; b=U52eaBZj3XeAC/39yA63p9JGKYbo/cLzHcN33Bp/p8RqZfafHZHEMWRa+f2LDjt4GU IYPrLCBZ3OfiffJYByEdgb7fmi1dqdby5ZsVW/sMXC3ZS50XnfMXaxZ8SOOpqKri6/xn 6UEr0l+JeUT9kXZD99ydccB0TakIS/sjM48n1a7HkfofEXjCZRlggiJ0hYaNhqM+UmCv coF7OQc8bV1eQBEbhJjIUcHvqkbW1yeAZY6JqlYitKovQvbmtW9MnDV0WbdMZUDnDuRg KMBTtoJCsllMcWaVZUJo3wOA4E/Vpf2VKSDJXht+oA2OFehm2RnTlxWggtK3IvTB/eqD JDzA== X-Gm-Message-State: AMCzsaWTVi8RFJ+qfATy66PFWxj5SjEI9ghFbGrNWym+LzH+yUfeZzlE Em6dNZMfSnc2tIuKHC7AxRk= X-Google-Smtp-Source: AOwi7QAyjDUhtr7A2UXI7+KTmbuS/c2KhdZ/GFTZX/ccSsvKJQk1Vj1RWtRwjv/R6FRjWpRRcKmvog== X-Received: by 10.98.204.69 with SMTP id a66mr937691pfg.132.1507264608564; Thu, 05 Oct 2017 21:36:48 -0700 (PDT) Received: from localhost.localdomain ([103.51.74.113]) by smtp.gmail.com with ESMTPSA id k126sm860111pfc.45.2017.10.05.21.36.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Oct 2017 21:36:48 -0700 (PDT) From: Anand Moon To: Rob Herring , Mark Rutland , Russell King , Kukjin Kim , Krzysztof Kozlowski , Kishon Vijay Abraham I , Bartlomiej Zolnierkiewicz , Lee Jones , Chunfeng Yun , Vivek Gautam , Anand Moon , Andrzej Pietrasiewicz Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk Date: Fri, 6 Oct 2017 04:36:35 +0000 Message-Id: <1507264595-3565-2-git-send-email-linux.amoon@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507264595-3565-1-git-send-email-linux.amoon@gmail.com> References: <1507264595-3565-1-git-send-email-linux.amoon@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP remove the disable and enable of phy clk. phy clk is needed to tune the phy controller. Before: mout_usbd300 1 1 24000000 0 0 dout_usbd300 0 0 24000000 0 0 sclk_usbd300 0 0 24000000 0 0 dout_usbphy300 1 1 24000000 0 0 sclk_usbphy300 3 3 24000000 0 0 mout_usbd301 1 1 24000000 0 0 dout_usbd301 0 0 24000000 0 0 sclk_usbd301 0 0 24000000 0 0 dout_usbphy301 1 1 24000000 0 0 sclk_usbphy301 2 2 24000000 0 0 After: mout_usbd300 2 2 24000000 0 0 dout_usbd300 1 1 24000000 0 0 sclk_usbd300 2 2 24000000 0 0 dout_usbphy300 1 1 24000000 0 0 sclk_usbphy300 3 3 24000000 0 0 mout_usbd301 2 2 24000000 0 0 dout_usbd301 1 1 24000000 0 0 sclk_usbd301 2 2 24000000 0 0 dout_usbphy301 1 1 24000000 0 0 sclk_usbphy301 2 2 24000000 0 0 Signed-off-by: Anand Moon --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 22c68f5..5e8054c 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -409,22 +409,15 @@ static int exynos5_usbdrd_phy_init(struct phy *phy) reg &= ~PHYCLKRST_PORTRESET; writel(reg, phy_drd->reg_phy + EXYNOS5_DRD_PHYCLKRST); - clk_disable_unprepare(phy_drd->clk); - return 0; } static int exynos5_usbdrd_phy_exit(struct phy *phy) { - int ret; u32 reg; struct phy_usb_instance *inst = phy_get_drvdata(phy); struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); - ret = clk_prepare_enable(phy_drd->clk); - if (ret) - return ret; - reg = PHYUTMI_OTGDISABLE | PHYUTMI_FORCESUSPEND | PHYUTMI_FORCESLEEP;