From patchwork Fri Apr 12 22:22:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 2438251 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 71E25DF2A1 for ; Fri, 12 Apr 2013 22:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577Ab3DLWXC (ORCPT ); Fri, 12 Apr 2013 18:23:02 -0400 Received: from gloria.sntech.de ([95.129.55.99]:45386 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998Ab3DLWXB (ORCPT ); Fri, 12 Apr 2013 18:23:01 -0400 Received: from 146-52-52-35-dynip.superkabel.de ([146.52.52.35] helo=marty.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UQmMt-0005Rn-Mc; Sat, 13 Apr 2013 00:22:51 +0200 From: Heiko =?utf-8?q?St=C3=BCbner?= To: Tomasz Figa Subject: Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Date: Sat, 13 Apr 2013 00:22:48 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) Cc: linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, kyungmin.park@samsung.com, linux@simtec.co.uk, broonie@opensource.wolfsonmicro.com, kwangwoo.lee@gmail.com, jacmet@sunsite.dk, augulis.darius@gmail.com, mcuelenaere@gmail.com, linux@arm.linux.org.uk, sylvester.nawrocki@gmail.com, buserror@gmail.com, christer@weinigel.se, jekhor@gmail.com, ghcstop@gmail.com, mark.rutland@arm.com, tomasz.figa@gmail.com, robherring2@gmail.com, m.szyprowski@samsung.com, arnd@arndb.de, john.stultz@linaro.org, tglx@linutronix.de References: <1365794250-14436-1-git-send-email-t.figa@samsung.com> In-Reply-To: <1365794250-14436-1-git-send-email-t.figa@samsung.com> MIME-Version: 1.0 Message-Id: <201304130022.49987.heiko@sntech.de> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Tomasz, Am Freitag, 12. April 2013, 21:17:16 schrieb Tomasz Figa: > This series is an attempt to make the samsung-time clocksource driver ready > for multiplatform kernels. It moves the driver to drivers/clocksource, > cleans it up from uses of static platform-specific definitions, simplifies > timer interrupt handling and adds Device Tree support. > > The samsung_pwm clocksource driver is made the master driver, which > exposes a single function to the PWM driver to get required data. Only > samsung-time driver is reworked to use the master driver at this time, > since the PWM driver can be already considered broken at the moment and > needs separate series of several patches to fix and clean it up, which > I am already working on. > > Tested on Universal C210 board with Device Tree. Not tested without > Device Tree, since it has been already broken before this series. > Compile tested for other related SoCs. On a s3c2416 based board with both non-dt and preliminary-dt support Tested-by: Heiko Stuebner One nitpick: Without dt support, you get this: CC drivers/clocksource/samsung_pwm.o drivers/clocksource/samsung_pwm.c:620: warning: ‘samsung_pwm_clocksource_init_of’ defined but not used So, something like the following might be necessary -------------- 8< ------------------- -------------- 8< ------------------- Heiko --- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clocksource/samsung_pwm.c b/drivers/clocksource/samsung_pwm.c index a12ee08..2bf8303 100644 --- a/drivers/clocksource/samsung_pwm.c +++ b/drivers/clocksource/samsung_pwm.c @@ -617,6 +617,7 @@ static void __init __samsung_pwm_clocksource_init( samsung_clocksource_init(); } +#ifdef CONFIG_CLKSRC_OF static void __init samsung_pwm_clocksource_init_of(struct device_node *np) { __samsung_pwm_clocksource_init(NULL, np); @@ -629,6 +630,7 @@ CLOCKSOURCE_OF_DECLARE(s5p6440_pwm, "samsung,s5p6440-pwm", samsung_pwm_clocksource_init_of); CLOCKSOURCE_OF_DECLARE(s5pc100_pwm, "samsung,s5pc100-pwm", samsung_pwm_clocksource_init_of); +#endif void __init samsung_pwm_clocksource_init(struct platform_device *pdev) {