From patchwork Tue Jun 21 05:15:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 9189503 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F23946075A for ; Tue, 21 Jun 2016 05:16:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E17BA27F99 for ; Tue, 21 Jun 2016 05:16:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D669C27FA5; Tue, 21 Jun 2016 05:16:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86EF327F99 for ; Tue, 21 Jun 2016 05:16:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932438AbcFUFPq (ORCPT ); Tue, 21 Jun 2016 01:15:46 -0400 Received: from mail.windriver.com ([147.11.1.11]:57072 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321AbcFUFPV (ORCPT ); Tue, 21 Jun 2016 01:15:21 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u5L5FGsW017959 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 20 Jun 2016 22:15:17 -0700 (PDT) Received: from yow-lpgnfs-02.corp.ad.wrs.com (128.224.149.8) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Mon, 20 Jun 2016 22:15:16 -0700 From: Paul Gortmaker To: CC: Paul Gortmaker , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , , Subject: [PATCH 4/5] PM / devfreq: make event/exynos-nocp explicitly non-modular Date: Tue, 21 Jun 2016 01:15:00 -0400 Message-ID: <20160621051501.18396-5-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20160621051501.18396-1-paul.gortmaker@windriver.com> References: <20160621051501.18396-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Kconfig currently controlling compilation of this code is: event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Chanwoo Choi Cc: MyungJoo Ham Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Paul Gortmaker --- drivers/devfreq/event/exynos-nocp.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index 6b6a5f310486..f954578abfdf 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -10,7 +10,7 @@ */ #include -#include +#include #include #include #include @@ -280,25 +280,12 @@ static int exynos_nocp_probe(struct platform_device *pdev) return 0; } -static int exynos_nocp_remove(struct platform_device *pdev) -{ - struct exynos_nocp *nocp = platform_get_drvdata(pdev); - - clk_disable_unprepare(nocp->clk); - - return 0; -} - static struct platform_driver exynos_nocp_driver = { .probe = exynos_nocp_probe, - .remove = exynos_nocp_remove, .driver = { .name = "exynos-nocp", + .suppress_bind_attrs = true, .of_match_table = exynos_nocp_id_match, }, }; -module_platform_driver(exynos_nocp_driver); - -MODULE_DESCRIPTION("Exynos NoC (Network on Chip) Probe driver"); -MODULE_AUTHOR("Chanwoo Choi "); -MODULE_LICENSE("GPL"); +builtin_platform_driver(exynos_nocp_driver);