From patchwork Wed May 24 15:58:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9746327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 48509601C2 for ; Wed, 24 May 2017 15:59:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35B912236A for ; Wed, 24 May 2017 15:59:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27CA0289B4; Wed, 24 May 2017 15:59:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8EE42236A for ; Wed, 24 May 2017 15:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759445AbdEXP7a (ORCPT ); Wed, 24 May 2017 11:59:30 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:61773 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758434AbdEXP73 (ORCPT ); Wed, 24 May 2017 11:59:29 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MIlvk-1dFkXm2d20-002DOx; Wed, 24 May 2017 17:58:46 +0200 From: Arnd Bergmann To: Kukjin Kim , Krzysztof Kozlowski Cc: Eric Anholt , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080 Date: Wed, 24 May 2017 17:58:34 +0200 Message-Id: <20170524155845.1778223-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:L4MED6OlKmfmcFGexWYauhkx3HdQRxmt4yESVdCPIGR4LJSCn9K E30u9vlrUP8KYOjvRg34Rq4jxhy1Eeyzl91a1mjbnJt1cRYau8tIFr/PRU7vcuiBp/2qLrW bQleiCkTSxR+PfzFlQmIBIUqUt7awktPYo1KjPnRnxKiV1I+uwgvCB39REYq9gSr4Ah0wdW 5spZQzZ/ThEhr816dL3kQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:yUk8rXXk1Wc=:jTdAAdAu1TnsQcwYwv22NU G/e1+cweB/QEQ3BXqbHELGnyh8Y+V6n7FDRus42owFvNZEUKOfqN6JmUyPjfKfJj/Jg7bvWpw xddyUic8RgTPubecaD+6XLy9lLNU//etUxxlAFaxhZPC/uHPlbcmWDk6eRh5LuOgK7MPC9Fhw 8qsTV8FGuMx/ocNteEqi0nxyywae5x1h/aLPiKIQ0OcEc8DuTBJhRRyFuABytRUlMBc+9hDCs EwIifIXnpJnGozQ89hDjimHf2sBlwqlgk2UmucZvaVTzOTO46QCXnr1JujJzDKw0D54dbuQpR GssjwrMfFeiQjAmCOqkU17jjiOuFMoDfIMSI79H0Cxz3xHqG0LShCRVG3UU5RCdueQE2PcftT AWZoEVKs+7KOdgc4KP8wuI+xE2j9t7EMt3GZU7ZxKlFt/F62qx85ALqSQ2vZgk7DzQufS7Iyy P4jjHllgIUYrvhDTOpFHEzTwfuQjgbOJYJSUQlg1wGurlr7BaEYSVnCTztJ+YbunT33hsnBeC X1TjaexS3bT++fcbPefJbL3XAfhb2g3Y4jFB7STuG9onzWklkY/4GkJCEis+vC8JzZcH1mLRJ 5hVoWSMisDg8LbM3EBincpGjPti2hajVr72ayC9wLamu5OZdb2g3buOULPx42AP37+oEZcSSs ARCkQ1SQWvjE19aRrBd5o43TmnC5DH8aZtIAbyst4pK167rD3nJ3UzBWKHSxGlHJxzyQ= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While trying a fix a build warning unrelated to s3c64xx, I ran into a circular dependency: drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:63: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:381: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:369: symbol FB_CYBER2000 depends on FB drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:72: symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER drivers/gpu/drm/Kconfig:137: symbol DRM_KMS_CMA_HELPER is selected by DRM_PL111 drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on ARM_AMBA drivers/amba/Kconfig:1: symbol ARM_AMBA is selected by S3C64XX_PL080 arch/arm/mach-s3c64xx/Kconfig:42: symbol S3C64XX_PL080 default value contains DMADEVICES drivers/dma/Kconfig:5: symbol DMADEVICES is selected by SND_SOC_SH4_SIU sound/soc/sh/Kconfig:29: symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR sound/soc/sh/Kconfig:59: symbol SND_SIU_MIGOR depends on I2C The I2C and FB dependencies are hard to untangle, but I notice that S3C64XX_PL080 selecting ARM_AMBA is one piece of the puzzle that can easily be avoided, as ARCH_S3C64XX already select ARM_AMBA. Removing the redundant 'select' now can help us in the future if we run into a variation of the same dependency. Signed-off-by: Arnd Bergmann --- Please apply this to the samsung tree --- arch/arm/mach-s3c64xx/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig index 459214fa20b4..5ee5ad74a3d6 100644 --- a/arch/arm/mach-s3c64xx/Kconfig +++ b/arch/arm/mach-s3c64xx/Kconfig @@ -40,7 +40,6 @@ config CPU_S3C6410 config S3C64XX_PL080 def_bool DMADEVICES - select ARM_AMBA select AMBA_PL08X config S3C64XX_SETUP_SDHCI