From patchwork Tue Dec 12 11:02:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 10106669 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 124256032B for ; Tue, 12 Dec 2017 11:03:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C3DE29B7D for ; Tue, 12 Dec 2017 11:03:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00E1129B81; Tue, 12 Dec 2017 11:03:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D39BD29B7D for ; Tue, 12 Dec 2017 11:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdLLLD1 (ORCPT ); Tue, 12 Dec 2017 06:03:27 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:17791 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbdLLLDZ (ORCPT ); Tue, 12 Dec 2017 06:03:25 -0500 Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20171212110323epoutp043ad2ded6a0837e0632e4478be3886c70~-hyeXUJ9O2765727657epoutp04K; Tue, 12 Dec 2017 11:03:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171212110323epoutp043ad2ded6a0837e0632e4478be3886c70~-hyeXUJ9O2765727657epoutp04K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1513076603; bh=wN2st4zWHHnYHvZKTJhlDW4t8IYrpQz4cf3SR45teOc=; h=From:To:Cc:Subject:Date:References:From; b=WntN1tP+zo1af1vY+BwYumex/y1hZpkU4/mPGw2M0f4B3eZu3TXt5i68swsEz2hFG ztrRUzBZBKb4sTjj5PM+gJj5TOP1D1XJFbssf6/qFOcPaa3SzEnl4MrOG9Ol6v8n2+ 12zXe1kY6LyaNJV1Ti9E17Xjp0K/kQTvT99+JzYQ= Received: from epsmges2p1.samsung.com (unknown [182.195.42.69]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20171212110323epcas2p4792f18d56d2220e2ef747eb377b14504~-hydvX3Nw1363613636epcas2p4I; Tue, 12 Dec 2017 11:03:23 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id CE.75.04343.B77BF2A5; Tue, 12 Dec 2017 20:03:23 +0900 (KST) Received: from epsmgms2p2new.samsung.com (unknown [182.195.42.143]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20171212110322epcas2p11e3f36ba3de73a03f062b7877d797d2a~-hydZ8KeA2395523955epcas2p1X; Tue, 12 Dec 2017 11:03:22 +0000 (GMT) X-AuditID: b6c32a45-e7bff700000010f7-d6-5a2fb77b3e94 Received: from epmmp1.local.host ( [203.254.227.16]) by epsmgms2p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 88.13.03909.A77BF2A5; Tue, 12 Dec 2017 20:03:22 +0900 (KST) Received: from AMDC3061.digital.local ([106.116.147.40]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P0U000ZDHCZOC50@mmp1.samsung.com>; Tue, 12 Dec 2017 20:03:22 +0900 (KST) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, a.hajda@samsung.com, jtp.park@samsung.com, kamil@wypas.org, smitha.t@samsung.com, b.zolnierkie@samsung.com, Sylwester Nawrocki Subject: [PATCH] s5p-mfc: Fix encoder menu controls initialization Date: Tue, 12 Dec 2017 12:02:46 +0100 Message-id: <20171212110246.11463-1-s.nawrocki@samsung.com> X-Mailer: git-send-email 2.14.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWy7bCmmW71dv0og8uLeCxurTvHarFxxnpW iyNrrzJZzDzRzmqx6fE1VoueDVtZLWac38dkcfgNUOzunm2MDpwem5fUe/RtWcXo8XmTnMeV I43sASxRXDYpqTmZZalF+nYJXBnnzz1kK1jOUXFg803WBsZW9i5GDg4JAROJ222yXYxcHEIC OxgldryZy9bFyAnkfGeUODHdBsQGqdmz7QULRNFuRomWr3dZIYp+MUqcbkoEsdkEDCV6j/Yx gtgiAvIST3pvsIE0MAu8App67iFYg7CAk8SB+y3MIJtZBFQlNj9VAgnzClhLNN5bywaxTF7i /YL7jCC9EgI/WSXWNcEkXCSO72higbCFJV4d38IOYUtLPFu1EaqhH+jqNc1QzgxGiTvtE5gg qqwlDh+/CHYFswCfRMfhv1D/80p0tAlBlHhI/N32kxHCdpQ4ePAPM8SXsRKNR5czT2CUXMDI sIpRLLWgODc9tdiowFCvODG3uDQvXS85P3cTIzgGtVx3MM4453OIUYCDUYmHd0OXXpQQa2JZ cWXuIUYJDmYlEd7uJv0oId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rz1265FCAmkJ5akZqemFqQW wWSZODilGhj1Rdyqz7w9cE3aU7l7D3f3n2sKCRmrDXbqVBnebA9qDzS9nP1iamWss5q8Uuh8 8WVaxv/OGb1fqcT/u6O523fOstpjh+YEmHDUTPW5uvrX3M09yXu6lPZ45lry7fgq8Z1p7vyf 8xLPnp8Yyja3TlzUa9PZ3ImbZ2kryN33/qA6/eTxQz2PzTcpsRRnJBpqMRcVJwIAgmdynL0C AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOJMWRmVeSWpSXmKPExsVy+t9jAd2q7fpRBq//6FvcWneO1WLjjPWs FkfWXmWymHmindVi0+NrrBY9G7ayWsw4v4/J4vAboNjdPdsYHTg9Ni+p9+jbsorR4/MmOY8r RxrZA1iiuGxSUnMyy1KL9O0SuDLOn3vIVrCco+LA5pusDYyt7F2MnBwSAiYSe7a9YOli5OIQ EtjJKDHpw3NGkISQwC9GiRP9wSA2m4ChRO/RPrC4iIC8xJPeG2wgDcwCrxglDn0+BJYQFnCS OHC/hbmLkYODRUBVYvNTJZAwr4C1ROO9tWwQy+Ql3i+4zziBkWsBI8MqRsnUguLc9NxiowKj vNRyveLE3OLSvHS95PzcTYzA4Nh2WKt/B+PjJfGHGAU4GJV4eDd06UUJsSaWFVfmHmKU4GBW EuHtbtKPEuJNSaysSi3Kjy8qzUktPsQozcGiJM7Ln38sUkggPbEkNTs1tSC1CCbLxMEp1cB4 JFU+reB+Gv/Jv4nKxY3FVQZv1baqvvsczGt8+l+v6N2rvOs0WvV3zD1RHhq39pyRweON3h88 eedoWOy/lrto7gfBS22clU0rpb23+OueuVc0v35L6sE5Lh/nejJL3/hYYBXYl7xWuyIj58Vd LhejJ0urjt+znxxz5MnNoCcm82JPf77/3OGzEktxRqKhFnNRcSIAm1X4EgoCAAA= X-CMS-MailID: 20171212110322epcas2p11e3f36ba3de73a03f062b7877d797d2a X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171212110322epcas2p11e3f36ba3de73a03f062b7877d797d2a X-RootMTR: 20171212110322epcas2p11e3f36ba3de73a03f062b7877d797d2a References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the menu_skip_mask field initialization and addresses a following issue found by the SVACE static analysis: * NO_EFFECT.SELF: assignment to self in expression 'cfg.menu_skip_mask = cfg.menu_skip_mask' No effect at drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:2083 Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c index 2a5fd7c42cd5..0d5d465561be 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c @@ -2080,7 +2080,7 @@ int s5p_mfc_enc_ctrls_setup(struct s5p_mfc_ctx *ctx) if (cfg.type == V4L2_CTRL_TYPE_MENU) { cfg.step = 0; - cfg.menu_skip_mask = cfg.menu_skip_mask; + cfg.menu_skip_mask = controls[i].menu_skip_mask; cfg.qmenu = mfc51_get_menu(cfg.id); } else { cfg.step = controls[i].step;