| Message ID | 20171218123805.26345-4-simon@lineageos.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Dec 18, 2017 at 1:38 PM, Simon Shields <simon@lineageos.org> wrote: > "midas" is the codename for a family of smartphones released by Samsung > Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy > Note 2 (GT-N7100/N7105). The boards largely have the same peripherals: > the main differences are touchscreen, display panel and cellular modem. > > Signed-off-by: Simon Shields <simon@lineageos.org> > --- > arch/arm/boot/dts/Makefile | 3 +++ > arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++ > arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++ > arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 84 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts > create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts > create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 66e28af289da..035abd66b472 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > exynos4210-trats.dtb \ > exynos4210-universal_c210.dtb \ > exynos4412-itop-elite.dtb \ > + exynos4412-m0.dtb \ > + exynos4412-m3.dtb \ > exynos4412-odroidu3.dtb \ > exynos4412-odroidx.dtb \ > exynos4412-odroidx2.dtb \ > exynos4412-origen.dtb \ > exynos4412-smdk4412.dtb \ > + exynos4412-t0.dtb \ > exynos4412-tiny4412.dtb \ > exynos4412-trats2.dtb > dtb-$(CONFIG_ARCH_EXYNOS5) += \ > diff --git a/arch/arm/boot/dts/exynos4412-m0.dts b/arch/arm/boot/dts/exynos4412-m0.dts > new file mode 100644 > index 000000000000..56c1ea6b5695 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4412-m0.dts > @@ -0,0 +1,27 @@ > +/* > + * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source > + * > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * Device tree source file for Samsung's M0 board which is based on > + * Samsung's Exynos4412 SoC. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +/dts-v1/; > +#include "exynos4412-galaxy-s3.dtsi" > + > +/ { > + model = "Samsung M0 (GT-I9300) based on Exynos4412"; > + compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x40000000 0x40000000>; I think each board has the same memory so maybe this can be made part of midas.dtsi? > + }; What about bootargs? > + Unneeded new line. > +}; > diff --git a/arch/arm/boot/dts/exynos4412-m3.dts b/arch/arm/boot/dts/exynos4412-m3.dts > new file mode 100644 > index 000000000000..80431044f07a > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4412-m3.dts > @@ -0,0 +1,14 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/dts-v1/; > +#include "exynos4412-galaxy-s3.dtsi" > + > +/ { > + model = "Samsung M3 (GT-I9305) based on Exynos4412"; > + compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x40000000 0x80000000>; > + }; > + Ditto > +}; > diff --git a/arch/arm/boot/dts/exynos4412-t0.dts b/arch/arm/boot/dts/exynos4412-t0.dts > new file mode 100644 > index 000000000000..1444e893fb0e > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4412-t0.dts > @@ -0,0 +1,40 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/dts-v1/; > +#include "exynos4412-midas.dtsi" > + > +/ { > + compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > + model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412"; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x40000000 0x80000000>; > + }; > +}; > + > +&buck9_reg { > + maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>; > + status = "okay"; > +}; > + > +&cam_io_reg { > + gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>; > + status = "okay"; > +}; > + > +&cam_af_reg { > + gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>; > + status = "okay"; > +}; Please but the cam nodes in alphabetical order. > + > +&ldo13_reg { > + regulator-name = "VCC_1.8V_LCD"; > + regulator-always-on; > +}; > + > +&ldo25_reg { > + regulator-name = "VCI_3.0V_LCD"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + status = "okay"; > +}; > -- > 2.15.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, On Wed, Dec 20, 2017 at 03:08:27PM +0100, Krzysztof Kozlowski wrote: > On Mon, Dec 18, 2017 at 1:38 PM, Simon Shields <simon@lineageos.org> wrote: > > "midas" is the codename for a family of smartphones released by Samsung > > Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy > > Note 2 (GT-N7100/N7105). The boards largely have the same peripherals: > > the main differences are touchscreen, display panel and cellular modem. > > > > Signed-off-by: Simon Shields <simon@lineageos.org> > > --- > > arch/arm/boot/dts/Makefile | 3 +++ > > arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++ > > arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++ > > arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++ > > 4 files changed, 84 insertions(+) > > create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts > > create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts > > create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 66e28af289da..035abd66b472 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > > exynos4210-trats.dtb \ > > exynos4210-universal_c210.dtb \ > > exynos4412-itop-elite.dtb \ > > + exynos4412-m0.dtb \ > > + exynos4412-m3.dtb \ > > exynos4412-odroidu3.dtb \ > > exynos4412-odroidx.dtb \ > > exynos4412-odroidx2.dtb \ > > exynos4412-origen.dtb \ > > exynos4412-smdk4412.dtb \ > > + exynos4412-t0.dtb \ > > exynos4412-tiny4412.dtb \ > > exynos4412-trats2.dtb > > dtb-$(CONFIG_ARCH_EXYNOS5) += \ > > diff --git a/arch/arm/boot/dts/exynos4412-m0.dts b/arch/arm/boot/dts/exynos4412-m0.dts > > new file mode 100644 > > index 000000000000..56c1ea6b5695 > > --- /dev/null > > +++ b/arch/arm/boot/dts/exynos4412-m0.dts > > @@ -0,0 +1,27 @@ > > +/* > > + * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source > > + * > > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. > > + * http://www.samsung.com > > + * > > + * Device tree source file for Samsung's M0 board which is based on > > + * Samsung's Exynos4412 SoC. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > + > > +/dts-v1/; > > +#include "exynos4412-galaxy-s3.dtsi" > > + > > +/ { > > + model = "Samsung M0 (GT-I9300) based on Exynos4412"; > > + compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > > + > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0x40000000 0x40000000>; > > I think each board has the same memory so maybe this can be made part > of midas.dtsi? T0 and M3 have 2GB of RAM, trats2/M0 have 1GB. > > > + }; > > What about bootargs? Handled by the bootloader - to work around the proprietary bootloader not supporting device tree and requiring hacks to successfully boot a mainline kernel, i'm using kexec from a suitably patched kernel to load and boot the "real" kernel. (This also means one image can be used across all boards). > > > + > > Unneeded new line. > > > +}; > > diff --git a/arch/arm/boot/dts/exynos4412-m3.dts b/arch/arm/boot/dts/exynos4412-m3.dts > > new file mode 100644 > > index 000000000000..80431044f07a > > --- /dev/null > > +++ b/arch/arm/boot/dts/exynos4412-m3.dts > > @@ -0,0 +1,14 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/dts-v1/; > > +#include "exynos4412-galaxy-s3.dtsi" > > + > > +/ { > > + model = "Samsung M3 (GT-I9305) based on Exynos4412"; > > + compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > > + > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0x40000000 0x80000000>; > > + }; > > + > > Ditto > > > +}; > > diff --git a/arch/arm/boot/dts/exynos4412-t0.dts b/arch/arm/boot/dts/exynos4412-t0.dts > > new file mode 100644 > > index 000000000000..1444e893fb0e > > --- /dev/null > > +++ b/arch/arm/boot/dts/exynos4412-t0.dts > > @@ -0,0 +1,40 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/dts-v1/; > > +#include "exynos4412-midas.dtsi" > > + > > +/ { > > + compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; > > + model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412"; > > + > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0x40000000 0x80000000>; > > + }; > > +}; > > + > > +&buck9_reg { > > + maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > +}; > > + > > +&cam_io_reg { > > + gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > +}; > > + > > +&cam_af_reg { > > + gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > +}; > > Please but the cam nodes in alphabetical order. > > > + > > +&ldo13_reg { > > + regulator-name = "VCC_1.8V_LCD"; > > + regulator-always-on; > > +}; > > + > > +&ldo25_reg { > > + regulator-name = "VCI_3.0V_LCD"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + status = "okay"; > > +}; > > -- > > 2.15.1 > > Cheers, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 20, 2017 at 4:33 PM, Simon Shields <simon@lineageos.org> wrote: > Hi Krzysztof, > > On Wed, Dec 20, 2017 at 03:08:27PM +0100, Krzysztof Kozlowski wrote: >> On Mon, Dec 18, 2017 at 1:38 PM, Simon Shields <simon@lineageos.org> wrote: >> > "midas" is the codename for a family of smartphones released by Samsung >> > Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy >> > Note 2 (GT-N7100/N7105). The boards largely have the same peripherals: >> > the main differences are touchscreen, display panel and cellular modem. >> > >> > Signed-off-by: Simon Shields <simon@lineageos.org> >> > --- >> > arch/arm/boot/dts/Makefile | 3 +++ >> > arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++ >> > arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++ >> > arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++ >> > 4 files changed, 84 insertions(+) >> > create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts >> > create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts >> > create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts >> > >> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> > index 66e28af289da..035abd66b472 100644 >> > --- a/arch/arm/boot/dts/Makefile >> > +++ b/arch/arm/boot/dts/Makefile >> > @@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ >> > exynos4210-trats.dtb \ >> > exynos4210-universal_c210.dtb \ >> > exynos4412-itop-elite.dtb \ >> > + exynos4412-m0.dtb \ >> > + exynos4412-m3.dtb \ >> > exynos4412-odroidu3.dtb \ >> > exynos4412-odroidx.dtb \ >> > exynos4412-odroidx2.dtb \ >> > exynos4412-origen.dtb \ >> > exynos4412-smdk4412.dtb \ >> > + exynos4412-t0.dtb \ >> > exynos4412-tiny4412.dtb \ >> > exynos4412-trats2.dtb >> > dtb-$(CONFIG_ARCH_EXYNOS5) += \ >> > diff --git a/arch/arm/boot/dts/exynos4412-m0.dts b/arch/arm/boot/dts/exynos4412-m0.dts >> > new file mode 100644 >> > index 000000000000..56c1ea6b5695 >> > --- /dev/null >> > +++ b/arch/arm/boot/dts/exynos4412-m0.dts >> > @@ -0,0 +1,27 @@ >> > +/* >> > + * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source >> > + * >> > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. >> > + * http://www.samsung.com >> > + * >> > + * Device tree source file for Samsung's M0 board which is based on >> > + * Samsung's Exynos4412 SoC. >> > + * >> > + * This program is free software; you can redistribute it and/or modify >> > + * it under the terms of the GNU General Public License version 2 as >> > + * published by the Free Software Foundation. >> > + */ >> > + >> > +/dts-v1/; >> > +#include "exynos4412-galaxy-s3.dtsi" >> > + >> > +/ { >> > + model = "Samsung M0 (GT-I9300) based on Exynos4412"; >> > + compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; >> > + >> > + memory@40000000 { >> > + device_type = "memory"; >> > + reg = <0x40000000 0x40000000>; >> >> I think each board has the same memory so maybe this can be made part >> of midas.dtsi? > > T0 and M3 have 2GB of RAM, trats2/M0 have 1GB. Ah, ok. > >> >> > + }; >> >> What about bootargs? > > Handled by the bootloader - to work around the proprietary bootloader not > supporting device tree and requiring hacks to successfully boot a > mainline kernel, i'm using kexec from a suitably patched kernel to load > and boot the "real" kernel. (This also means one image can be used > across all boards). Could you document it in DTS why bootargs are missing? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 66e28af289da..035abd66b472 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ exynos4210-trats.dtb \ exynos4210-universal_c210.dtb \ exynos4412-itop-elite.dtb \ + exynos4412-m0.dtb \ + exynos4412-m3.dtb \ exynos4412-odroidu3.dtb \ exynos4412-odroidx.dtb \ exynos4412-odroidx2.dtb \ exynos4412-origen.dtb \ exynos4412-smdk4412.dtb \ + exynos4412-t0.dtb \ exynos4412-tiny4412.dtb \ exynos4412-trats2.dtb dtb-$(CONFIG_ARCH_EXYNOS5) += \ diff --git a/arch/arm/boot/dts/exynos4412-m0.dts b/arch/arm/boot/dts/exynos4412-m0.dts new file mode 100644 index 000000000000..56c1ea6b5695 --- /dev/null +++ b/arch/arm/boot/dts/exynos4412-m0.dts @@ -0,0 +1,27 @@ +/* + * Samsung's Exynos4412 based M0 (GT-I9300) board device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Device tree source file for Samsung's M0 board which is based on + * Samsung's Exynos4412 SoC. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/dts-v1/; +#include "exynos4412-galaxy-s3.dtsi" + +/ { + model = "Samsung M0 (GT-I9300) based on Exynos4412"; + compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; + + memory@40000000 { + device_type = "memory"; + reg = <0x40000000 0x40000000>; + }; + +}; diff --git a/arch/arm/boot/dts/exynos4412-m3.dts b/arch/arm/boot/dts/exynos4412-m3.dts new file mode 100644 index 000000000000..80431044f07a --- /dev/null +++ b/arch/arm/boot/dts/exynos4412-m3.dts @@ -0,0 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "exynos4412-galaxy-s3.dtsi" + +/ { + model = "Samsung M3 (GT-I9305) based on Exynos4412"; + compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; + + memory@40000000 { + device_type = "memory"; + reg = <0x40000000 0x80000000>; + }; + +}; diff --git a/arch/arm/boot/dts/exynos4412-t0.dts b/arch/arm/boot/dts/exynos4412-t0.dts new file mode 100644 index 000000000000..1444e893fb0e --- /dev/null +++ b/arch/arm/boot/dts/exynos4412-t0.dts @@ -0,0 +1,40 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; +#include "exynos4412-midas.dtsi" + +/ { + compatible = "samsung,t0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4"; + model = "Samsung T0 (GT-N7100, GT-N7105) based on Exynos4412"; + + memory@40000000 { + device_type = "memory"; + reg = <0x40000000 0x80000000>; + }; +}; + +&buck9_reg { + maxim,ena-gpios = <&gpm1 0 GPIO_ACTIVE_HIGH>; + status = "okay"; +}; + +&cam_io_reg { + gpio = <&gpm0 7 GPIO_ACTIVE_HIGH>; + status = "okay"; +}; + +&cam_af_reg { + gpio = <&gpm1 1 GPIO_ACTIVE_HIGH>; + status = "okay"; +}; + +&ldo13_reg { + regulator-name = "VCC_1.8V_LCD"; + regulator-always-on; +}; + +&ldo25_reg { + regulator-name = "VCI_3.0V_LCD"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + status = "okay"; +};
"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals: the main differences are touchscreen, display panel and cellular modem. Signed-off-by: Simon Shields <simon@lineageos.org> --- arch/arm/boot/dts/Makefile | 3 +++ arch/arm/boot/dts/exynos4412-m0.dts | 27 +++++++++++++++++++++++++ arch/arm/boot/dts/exynos4412-m3.dts | 14 +++++++++++++ arch/arm/boot/dts/exynos4412-t0.dts | 40 +++++++++++++++++++++++++++++++++++++ 4 files changed, 84 insertions(+) create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts