From patchwork Tue Mar 13 10:27:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 10278117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 833E46038F for ; Tue, 13 Mar 2018 10:27:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6720C28355 for ; Tue, 13 Mar 2018 10:27:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B94428A5F; Tue, 13 Mar 2018 10:27:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D124C28355 for ; Tue, 13 Mar 2018 10:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932566AbeCMK1Y (ORCPT ); Tue, 13 Mar 2018 06:27:24 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44423 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932521AbeCMK1X (ORCPT ); Tue, 13 Mar 2018 06:27:23 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180313102720euoutp026522d9743f04bc65173ff5ead2f60e3a~bc-_izvgv0370703707euoutp02H; Tue, 13 Mar 2018 10:27:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180313102720euoutp026522d9743f04bc65173ff5ead2f60e3a~bc-_izvgv0370703707euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1520936840; bh=6HMUZ9ymlMbUhYZQrqAvZi3pKMl5ALOHaB4oK1f2AQY=; h=From:To:Cc:Subject:Date:References:From; b=vahd99yL/gOvfJPEqWbsjK3MMJCNk/HVkQ3oZ3aSfjJCdY36LipUd4+OmHq/ko9am /B/GiXv2hHPbokotQPC3rRxbmX6+dIxg6O6gMGSUYhf5x/OKTWjYCKGyA7XJgeickX 0+D2t9zZ20LGFZUD5QjzN1HpYrSGqdtF77eIC3fI= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180313102720eucas1p2bac18b8903b0d2c66fac0a42dc6a39fc~bc-9w7Z740091400914eucas1p2J; Tue, 13 Mar 2018 10:27:20 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id C4.71.05700.787A7AA5; Tue, 13 Mar 2018 10:27:19 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180313102719eucas1p1723f61b6e082a282baf04ed3065cc0ec~bc-9JhghD0246002460eucas1p1q; Tue, 13 Mar 2018 10:27:19 +0000 (GMT) X-AuditID: cbfec7f2-1c1ff70000011644-28-5aa7a7874cb6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F9.61.04178.787A7AA5; Tue, 13 Mar 2018 10:27:19 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P5I00BZ0YDG9J10@eusync3.samsung.com>; Tue, 13 Mar 2018 10:27:19 +0000 (GMT) From: Marek Szyprowski To: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Andrzej Hajda Subject: [PATCH] media: s5p-mfc: Use real device for request_firmware() call Date: Tue, 13 Mar 2018 11:27:10 +0100 Message-id: <20180313102710.23699-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.15.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42LZduzned325cujDCYtMrG4te4cq0XPhq2s FjPO72OyWHvkLrvF4TftrA6sHn1bVjF6fN4kF8AUxWWTkpqTWZZapG+XwJXx/MhK1oJ/nBV/ 9sk3MO7h6GLk5JAQMJF49GsBYxcjF4eQwApGiTvfN0I5nxklFt/7zNLFyAFWteFDAkR8GaPE q7N3mCCcBiaJ9U/XsYKMYhMwlOh628UGYosIOEksnPWXHaSIWaCZUeJ0+yOwhLCAj8TLOe1g DSwCqhJvHnwCs3kFbCWmN01lg7hJXmLx951sIM0SAidZJV4uuwyVcJG4vmItK4QtLPHq+BZ2 CFtGorPjIBOEXS/R9/0IE0RzD6PE3papUAlricPHL4I1MwvwSUzaNp0Z4jdeiY42IYgSD4nd P2YzQ9iOEsuPHGYEsYUEYiUOr/vOOIFRcgEjwypG8dTS4tz01GLDvNRyveLE3OLSvHS95Pzc TYzAaDr97/inHYxfLyUdYhTgYFTi4TVoXhYlxJpYVlyZe4hRgoNZSYTXrGd5lBBvSmJlVWpR fnxRaU5q8SFGaQ4WJXHeOI26KCGB9MSS1OzU1ILUIpgsEwenVANjq9+FtTodzX93651i2leg 8ULcw/1PxdEzcjW9xjc5ZTl4wtYcWtw0wUXbxpv3YctEj92/lnQn3zv6c/NJsy18tTFKt9Pu ljkKSG5d2xC0//eBH5lnWvwv5bMIaCvuOHLMfNGSYmllg2XfxOesPJc+j//UNN9roeornrGd KXKXPTN3oZzrQ8/DSizFGYmGWsxFxYkA/Bk4QaICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKJMWRmVeSWpSXmKPExsVy+t/xq7rty5dHGfzfJWlxa905VoueDVtZ LWac38dksfbIXXaLw2/aWR1YPfq2rGL0+LxJLoApissmJTUnsyy1SN8ugSvj+ZGVrAX/OCv+ 7JNvYNzD0cXIwSEhYCKx4UNCFyMXh5DAEkaJ/4/fMUI4TUwSk1onATmcHGwChhJdb7vYQGwR ASeJhbP+soMUMQu0Mkps3tzOApIQFvCReDmnnRXEZhFQlXjz4BOYzStgKzG9aSpYs4SAvMTi 7zvZJjByLWBkWMUoklpanJueW2yoV5yYW1yal66XnJ+7iRHo2W3Hfm7ewXhpY/AhRgEORiUe XoPmZVFCrIllxZW5hxglOJiVRHjNepZHCfGmJFZWpRblxxeV5qQWH2KU5mBREuc9b1AZJSSQ nliSmp2aWpBaBJNl4uCUamCMWpd7qXNm2YXO35HW7DOM575dev2uiKj+W5VWHrf3S6eZtJ96 evjtEVn3U5xxwk2N08/e+13zTFDlumhZk9BpXVWZrtXvrn9dJqPZPNd0RtZT36VBLpo5nzdW qP0/4Fn8NZP/6HTmhB/ClhFylw+Jzn9zsluxuix0utq5VbM4DRNuVBtbscgosRRnJBpqMRcV JwIAqyr6augBAAA= X-CMS-MailID: 20180313102719eucas1p1723f61b6e082a282baf04ed3065cc0ec X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180313102719eucas1p1723f61b6e082a282baf04ed3065cc0ec X-RootMTR: 20180313102719eucas1p1723f61b6e082a282baf04ed3065cc0ec References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Provide proper (real) struct device to request_firmware() call. This fixes following error messages: (NULL device *): Direct firmware load for s5p-mfc-v6-v2.fw failed with error -2 (NULL device *): Direct firmware load for s5p-mfc-v6.fw failed with error -2 into a bit more meaningful ones: s5p-mfc 11000000.codec: Direct firmware load for s5p-mfc-v6-v2.fw failed with error -2 s5p-mfc 11000000.codec: Direct firmware load for s5p-mfc-v6.fw failed with error -2 Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c index f95cd76af537..ef9ae969d307 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c @@ -62,7 +62,7 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) if (!dev->variant->fw_name[i]) continue; err = request_firmware((const struct firmware **)&fw_blob, - dev->variant->fw_name[i], dev->v4l2_dev.dev); + dev->variant->fw_name[i], &dev->plat_dev->dev); if (!err) { dev->fw_ver = (enum s5p_mfc_fw_ver) i; break;