| Message ID | 20180416181126.15629-2-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Apr 16, 2018 at 08:11:26PM +0200, Krzysztof Kozlowski wrote: > The PMU node is the actual block responsible for power management, > including typical Exynos on/off/restart procedures. Therefore the > syscon poweroff and restart nodes logically belong to it. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Previously was "Fix missing missing reg warning for syscon restart > nodes" to fix DTC warnings like: > > arch/arm64/boot/dts/exynos/exynos7-espresso.dtb: Warning (simple_bus_reg): > Node /soc/syscon-reboot missing or empty reg/ranges property > > but this warnings are gone in v4.17-rc1 since 9130ba884640 > ("scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987") > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++------- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 12 ++++++------ > 2 files changed, 13 insertions(+), 13 deletions(-) I forgot to include Marek's tested-by tag (given previously): Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index c0231d077fa6..01e49159dd91 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -231,13 +231,6 @@ cpu_on = <0xC4000003>; }; - reboot: syscon-reboot { - compatible = "syscon-reboot"; - regmap = <&pmu_system_controller>; - offset = <0x400>; /* SWRESET */ - mask = <0x1>; - }; - soc: soc { compatible = "simple-bus"; #address-cells = <1>; @@ -799,6 +792,13 @@ #clock-cells = <1>; clock-names = "clkout16"; clocks = <&xxti>; + + reboot: syscon-reboot { + compatible = "syscon-reboot"; + regmap = <&pmu_system_controller>; + offset = <0x400>; /* SWRESET */ + mask = <0x1>; + }; }; gic: interrupt-controller@11001000 { diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index ad9dce6894ce..0b98d2334cad 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -494,13 +494,13 @@ pmu_system_controller: system-controller@105c0000 { compatible = "samsung,exynos7-pmu", "syscon"; reg = <0x105c0000 0x5000>; - }; - reboot: syscon-reboot { - compatible = "syscon-reboot"; - regmap = <&pmu_system_controller>; - offset = <0x0400>; - mask = <0x1>; + reboot: syscon-reboot { + compatible = "syscon-reboot"; + regmap = <&pmu_system_controller>; + offset = <0x0400>; + mask = <0x1>; + }; }; rtc: rtc@10590000 {
The PMU node is the actual block responsible for power management, including typical Exynos on/off/restart procedures. Therefore the syscon poweroff and restart nodes logically belong to it. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Previously was "Fix missing missing reg warning for syscon restart nodes" to fix DTC warnings like: arch/arm64/boot/dts/exynos/exynos7-espresso.dtb: Warning (simple_bus_reg): Node /soc/syscon-reboot missing or empty reg/ranges property but this warnings are gone in v4.17-rc1 since 9130ba884640 ("scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987") --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++------- arch/arm64/boot/dts/exynos/exynos7.dtsi | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-)