| Message ID | 20191028152050.10220-3-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver | expand |
On Mon, Oct 28, 2019 at 04:20:50PM +0100, Sylwester Nawrocki wrote: > The "syscon" compatible string was introduced mainly to allow sharing > of the CHIPID IO region between multiple drivers. However, such sharing > can be also done without an additional compatible so remove "syscon". Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof > > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml > index 53c29d567789..afcd70803c12 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml > +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml > @@ -13,7 +13,6 @@ properties: > compatible: > items: > - const: samsung,exynos4210-chipid > - - const: syscon > > reg: > maxItems: 1 > @@ -34,7 +33,7 @@ required: > examples: > - | > chipid@10000000 { > - compatible = "samsung,exynos4210-chipid", "syscon"; > + compatible = "samsung,exynos4210-chipid"; > reg = <0x10000000 0x100>; > samsung,asv-bin = <2>; > }; > -- > 2.17.1 >
On Mon, 28 Oct 2019 16:20:50 +0100, Sylwester Nawrocki wrote: > The "syscon" compatible string was introduced mainly to allow sharing > of the CHIPID IO region between multiple drivers. However, such sharing > can be also done without an additional compatible so remove "syscon". > > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml index 53c29d567789..afcd70803c12 100644 --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml @@ -13,7 +13,6 @@ properties: compatible: items: - const: samsung,exynos4210-chipid - - const: syscon reg: maxItems: 1 @@ -34,7 +33,7 @@ required: examples: - | chipid@10000000 { - compatible = "samsung,exynos4210-chipid", "syscon"; + compatible = "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; samsung,asv-bin = <2>; };
The "syscon" compatible string was introduced mainly to allow sharing of the CHIPID IO region between multiple drivers. However, such sharing can be also done without an additional compatible so remove "syscon". Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)