| Message ID | 20191210143706.3928480-3-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/10] tty: serial: samsung: allow driver to be built by anyone | expand |
On Tue, Dec 10, 2019 at 03:36:59PM +0100, Greg Kroah-Hartman wrote: > checkpatch found some minor issues with comments in samsung.h, so fix > that up. > No, you remove this header two patches later. No point to fix checkpatch issues here. Best regards, Krzysztof > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/samsung.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > index f93022113f59..cdfd53acead3 100644 > --- a/drivers/tty/serial/samsung.h > +++ b/drivers/tty/serial/samsung.h > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +/* SPDX-License-Identifier: GPL-2.0 */ > #ifndef __SAMSUNG_H > #define __SAMSUNG_H > > @@ -7,7 +7,7 @@ > * > * Ben Dooks, Copyright (c) 2003-2008 Simtec Electronics > * http://armlinux.simtec.co.uk/ > -*/ > + */ > > #include <linux/dmaengine.h> > > -- > 2.24.0 >
On Tue, Dec 10, 2019 at 04:12:04PM +0100, Krzysztof Kozlowski wrote: > On Tue, Dec 10, 2019 at 03:36:59PM +0100, Greg Kroah-Hartman wrote: > > checkpatch found some minor issues with comments in samsung.h, so fix > > that up. > > > > No, you remove this header two patches later. No point to fix checkpatch > issues here. It's nice to delete "clean" files :)
diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h index f93022113f59..cdfd53acead3 100644 --- a/drivers/tty/serial/samsung.h +++ b/drivers/tty/serial/samsung.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ #ifndef __SAMSUNG_H #define __SAMSUNG_H @@ -7,7 +7,7 @@ * * Ben Dooks, Copyright (c) 2003-2008 Simtec Electronics * http://armlinux.simtec.co.uk/ -*/ + */ #include <linux/dmaengine.h>
checkpatch found some minor issues with comments in samsung.h, so fix that up. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/samsung.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)