| Message ID | 20200227093027.17349-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ARM: multi_v7_defconfig: make Samsung USB2 PHY built-in | expand |
On Thu, Feb 27, 2020 at 10:30:27AM +0100, Marek Szyprowski wrote: > Exynos OHCI and EHCI drivers are already selected as built-in, but they > both require Samsung USB2 Generic PHY driver to operate properly. Mark > that driver as built-in, otherwise having Exynos OHCI and EHCI drivers > built-in makes no sense. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) How about going the other way - making EHCI a module (OHCI is =m already)? multi_v7 requires initrd anyway for many boot configurations so such change would not affect much. Best regards, Krzysztof > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 7c8a1c310bbb..04a68efb3ddb 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -1055,7 +1055,7 @@ CONFIG_PHY_QCOM_APQ8064_SATA=m > CONFIG_PHY_RCAR_GEN2=m > CONFIG_PHY_ROCKCHIP_DP=m > CONFIG_PHY_ROCKCHIP_USB=y > -CONFIG_PHY_SAMSUNG_USB2=m > +CONFIG_PHY_SAMSUNG_USB2=y > CONFIG_PHY_EXYNOS5250_SATA=m > CONFIG_PHY_UNIPHIER_USB2=y > CONFIG_PHY_UNIPHIER_USB3=y > -- > 2.17.1 >
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 7c8a1c310bbb..04a68efb3ddb 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -1055,7 +1055,7 @@ CONFIG_PHY_QCOM_APQ8064_SATA=m CONFIG_PHY_RCAR_GEN2=m CONFIG_PHY_ROCKCHIP_DP=m CONFIG_PHY_ROCKCHIP_USB=y -CONFIG_PHY_SAMSUNG_USB2=m +CONFIG_PHY_SAMSUNG_USB2=y CONFIG_PHY_EXYNOS5250_SATA=m CONFIG_PHY_UNIPHIER_USB2=y CONFIG_PHY_UNIPHIER_USB3=y
Exynos OHCI and EHCI drivers are already selected as built-in, but they both require Samsung USB2 Generic PHY driver to operate properly. Mark that driver as built-in, otherwise having Exynos OHCI and EHCI drivers built-in makes no sense. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)