| Message ID | 20200713144930.1034632-7-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote: > No attempt has been made to document either of the demoted functions here. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend' > drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume' > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Thomas Abraham <thomas.ab@samsung.com> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- Thanks, applied. Best regards, Krzysztof
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote: > On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote: > > No attempt has been made to document either of the demoted functions here. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend' > > drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume' > > > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > > Cc: Thomas Abraham <thomas.ab@samsung.com> > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- > > Thanks, applied. Same as the others. Already in -next.
On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote: > On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote: > > > On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote: > > > No attempt has been made to document either of the demoted functions here. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend' > > > drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume' > > > > > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > > > Cc: Thomas Abraham <thomas.ab@samsung.com> > > > Cc: linux-samsung-soc@vger.kernel.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- > > > > Thanks, applied. > > Same as the others. Already in -next. Thanks for letting me know. I dropped all of them. Best regards, Krzysztof
On Mon, Jul 20, 2020 at 4:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote: > > > Thanks, applied. > > > > Same as the others. Already in -next. > > Thanks for letting me know. I dropped all of them. It's a bit tricky at times with clean-up topics, I want submaintainers to pick it up if possible so sorry about this, it's just too much to coordinate sometimes. Yours, Linus Walleij
On Thu, 23 Jul 2020 at 10:44, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Jul 20, 2020 at 4:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote: > > > > > Thanks, applied. > > > > > > Same as the others. Already in -next. > > > > Thanks for letting me know. I dropped all of them. > > It's a bit tricky at times with clean-up topics, I want submaintainers to pick > it up if possible so sorry about this, it's just too much to coordinate > sometimes. No worries. Recently Samsung pinctrl driver is not that active so I could just provide you only a review. Maybe there is too much hustle to apply to sub-maintainer tree. Best regards, Krzysztof
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index f26574ef234ab..608eb5a07248e 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -1140,7 +1140,7 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) return 0; } -/** +/* * samsung_pinctrl_suspend - save pinctrl state for suspend * * Save data for all banks handled by this device. @@ -1187,7 +1187,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev) return 0; } -/** +/* * samsung_pinctrl_resume - restore pinctrl state from suspend * * Restore one of the banks that was saved during suspend.
No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend' drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume' Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Thomas Abraham <thomas.ab@samsung.com> Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)