| Message ID | 20200713144930.1034632-9-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
On Mon, Jul 13, 2020 at 03:49:13PM +0100, Lee Jones wrote: > Kerneldoc struct titles must be followed by whitespace else the > checker gets confused. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data ' > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++--- Thanks, squashed with s3c24xx since these are similar issues and only documentation is affected. Best regards, Krzysztof
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote: > On Mon, Jul 13, 2020 at 03:49:13PM +0100, Lee Jones wrote: > > Kerneldoc struct titles must be followed by whitespace else the > > checker gets confused. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data ' > > > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++--- > > Thanks, squashed with s3c24xx since these are similar issues and only > documentation is affected. This is already in -next. Seems like an odd decision to squash them too.
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c index f97f8179f2b1b..b8166e3fe4cef 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c @@ -193,7 +193,7 @@ static const struct samsung_pin_bank_type bank_type_2bit_alive = { } /** - * struct s3c64xx_eint0_data: EINT0 common data + * struct s3c64xx_eint0_data - EINT0 common data * @drvdata: pin controller driver data * @domains: IRQ domains of particular EINT0 interrupts * @pins: pin offsets inside of banks of particular EINT0 interrupts @@ -205,7 +205,7 @@ struct s3c64xx_eint0_data { }; /** - * struct s3c64xx_eint0_domain_data: EINT0 per-domain data + * struct s3c64xx_eint0_domain_data - EINT0 per-domain data * @bank: pin bank related to the domain * @eints: EINT0 interrupts related to the domain */ @@ -215,7 +215,7 @@ struct s3c64xx_eint0_domain_data { }; /** - * struct s3c64xx_eint_gpio_data: GPIO EINT data + * struct s3c64xx_eint_gpio_data - GPIO EINT data * @drvdata: pin controller driver data * @domains: array of domains related to EINT interrupt groups */
Kerneldoc struct titles must be followed by whitespace else the checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data ' Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)