diff mbox series

[5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

Message ID 20201103124618.21358-6-l.stelmach@samsung.com (mailing list archive)
State Superseded
Headers show
Series Add Ethernet interface description for Odroid boards | expand

Commit Message

Lukasz Stelmach Nov. 3, 2020, 12:46 p.m. UTC 
Add Ethernet interface description for Odroid X/X2.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

Krzysztof Kozlowski Nov. 3, 2020, 4:44 p.m. UTC | #1 
On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X/X2.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> index 3ea2a0101e80..8f154f431f6c 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -15,6 +15,10 @@ / {
>  	model = "Hardkernel ODROID-X board based on Exynos4412";
>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>  
> +	aliases {
> +		ethernet = &ethernet;
> +	};
> +
>  	memory@40000000 {
>  		device_type = "memory";
>  		reg = <0x40000000 0x3FF00000>;
> @@ -72,8 +76,32 @@ &buck8_reg {
>  };
>  
>  &ehci {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  	phys = <&exynos_usbphy 2>;
>  	phy-names = "hsic0";
> +
> +	hub@2 {
> +		compatible = "usb0424,3503";
> +		reg = <2>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		hub@1 {
> +			compatible = "usb0424:9514";

Does not look like correct compatible.

Best regards,
Krzysztof
Lukasz Stelmach Nov. 3, 2020, 5:12 p.m. UTC | #2 
It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
>> Add Ethernet interface description for Odroid X/X2.
>> 
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 3ea2a0101e80..8f154f431f6c 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -15,6 +15,10 @@ / {
>>  	model = "Hardkernel ODROID-X board based on Exynos4412";
>>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>>  
>> +	aliases {
>> +		ethernet = &ethernet;
>> +	};
>> +
>>  	memory@40000000 {
>>  		device_type = "memory";
>>  		reg = <0x40000000 0x3FF00000>;
>> @@ -72,8 +76,32 @@ &buck8_reg {
>>  };
>>  
>>  &ehci {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>>  	phys = <&exynos_usbphy 2>;
>>  	phy-names = "hsic0";
>> +
>> +	hub@2 {
>> +		compatible = "usb0424,3503";
>> +		reg = <2>;
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		hub@1 {
>> +			compatible = "usb0424:9514";
>
> Does not look like correct compatible.

As odd as it may seem (and considering my mistakes) this is correct.

--8<---------------cut here---------------start------------->8---
root@target:~# cat /proc/device-tree/compatible ; echo
hardkernel,odroid-x2samsung,exynos4412samsung,exynos4
root@target:~# lsusb -t
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M
    |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/3p, 480M
        |__ Port 1: Dev 3, If 0, Class=Hub, Driver=hub/5p, 480M
            |__ Port 1: Dev 4, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
root@target:~# lsusb
Bus 001 Device 004: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 003: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp. 
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
--8<---------------cut here---------------end--------------->8---
Krzysztof Kozlowski Nov. 3, 2020, 5:22 p.m. UTC | #3 
On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> >>  1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >>      model = "Hardkernel ODROID-X board based on Exynos4412";
> >>      compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
> >>
> >> +    aliases {
> >> +            ethernet = &ethernet;
> >> +    };
> >> +
> >>      memory@40000000 {
> >>              device_type = "memory";
> >>              reg = <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >>  };
> >>
> >>  &ehci {
> >> +    #address-cells = <1>;
> >> +    #size-cells = <0>;
> >>      phys = <&exynos_usbphy 2>;
> >>      phy-names = "hsic0";
> >> +
> >> +    hub@2 {
> >> +            compatible = "usb0424,3503";
> >> +            reg = <2>;
> >> +            #address-cells = <1>;
> >> +            #size-cells = <0>;
> >> +
> >> +            hub@1 {
> >> +                    compatible = "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.

Not the numbers, the format. Comma is needed.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 3ea2a0101e80..8f154f431f6c 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -15,6 +15,10 @@  / {
 	model = "Hardkernel ODROID-X board based on Exynos4412";
 	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
 
+	aliases {
+		ethernet = &ethernet;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x3FF00000>;
@@ -72,8 +76,32 @@  &buck8_reg {
 };
 
 &ehci {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	phys = <&exynos_usbphy 2>;
 	phy-names = "hsic0";
+
+	hub@2 {
+		compatible = "usb0424,3503";
+		reg = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			compatible = "usb0424:9514";
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			ethernet: usbether@1 {
+				compatible = "usb0424,ec00";
+				reg = <1>;
+				local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+			};
+		};
+	};
+
+
 };
 
 &mshc_0 {