diff mbox series

[3/7] mfd: da9052: Simplify getting of_device_id match data

Message ID 20210419081726.67867-3-krzysztof.kozlowski@canonical.com (mailing list archive)
State Not Applicable
Headers show
Series [1/7] mfd: max8997: Simplify getting of_device_id match data | expand

Commit Message

Krzysztof Kozlowski April 19, 2021, 8:17 a.m. UTC
Use of_device_get_match_data() to make the code slightly smaller.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/mfd/da9052-i2c.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Adam Thomson April 19, 2021, 11 a.m. UTC | #1
On 19 April 2021 09:17, Krzysztof Kozlowski wrote:

> Use of_device_get_match_data() to make the code slightly smaller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

>  drivers/mfd/da9052-i2c.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 47556d2d9abe..5d8ce8dca3fc 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -154,13 +154,8 @@ static int da9052_i2c_probe(struct i2c_client *client,
>  		return ret;
> 
>  #ifdef CONFIG_OF
> -	if (!id) {
> -		struct device_node *np = client->dev.of_node;
> -		const struct of_device_id *deviceid;
> -
> -		deviceid = of_match_node(dialog_dt_ids, np);
> -		id = deviceid->data;
> -	}
> +	if (!id)
> +		id = of_device_get_match_data(&client->dev);
>  #endif
> 
>  	if (!id) {
> --
> 2.25.1
diff mbox series

Patch

diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index 47556d2d9abe..5d8ce8dca3fc 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -154,13 +154,8 @@  static int da9052_i2c_probe(struct i2c_client *client,
 		return ret;
 
 #ifdef CONFIG_OF
-	if (!id) {
-		struct device_node *np = client->dev.of_node;
-		const struct of_device_id *deviceid;
-
-		deviceid = of_match_node(dialog_dt_ids, np);
-		id = deviceid->data;
-	}
+	if (!id)
+		id = of_device_get_match_data(&client->dev);
 #endif
 
 	if (!id) {