| Message ID | 20210928235635.1348330-8-willmcvicker@google.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: Kconfig: Update ARCH_EXYNOS select configs | expand |
On 29/09/2021 01:56, Will McVicker wrote: > This sets the COMMON_CLK_SAMSUNG and EXYNOS_ARM64_COMMON_CLK drivers as > tristate so that we can compile them as modules. This is not the only thing you are doing. You are removing the enforced built-in and this must be here explained and tested. The policy so far was that all S3C, S5P and Exynos supported platforms select (enforce) necessary drivers. Please explain in commit msg reasoning why this is being changed and what's the impact (whether it actually works). What is more, it seems you entirely ignored Geert's comments. I pointed attention to it last time and you just said you will send v2 instead of joining discussion. It's a NAK for this reason - ignoring what Geert brought: you just broke distro configs for Exynos. Best regards, Krzysztof
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 30f930e20599..01b8e8b8d95d 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -12,7 +12,6 @@ menuconfig ARCH_EXYNOS select ARM_AMBA select ARM_GIC select EXYNOS_IRQ_COMBINER - select COMMON_CLK_SAMSUNG select EXYNOS_THERMAL select EXYNOS_PMU select EXYNOS_SROM diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx index f3fcb570edf5..f65117bb9f4c 100644 --- a/arch/arm/mach-s3c/Kconfig.s3c64xx +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx @@ -9,7 +9,6 @@ menuconfig ARCH_S3C64XX select ARM_AMBA select ARM_VIC select CLKSRC_SAMSUNG_PWM - select COMMON_CLK_SAMSUNG select GPIO_SAMSUNG if ATAGS select GPIOLIB select HAVE_S3C2410_I2C if I2C diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index d644b45bc29d..3d7e0b5739d8 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -10,7 +10,6 @@ config ARCH_S5PV210 depends on ARCH_MULTI_V7 select ARM_VIC select CLKSRC_SAMSUNG_PWM - select COMMON_CLK_SAMSUNG select GPIOLIB select HAVE_S3C2410_I2C if I2C select HAVE_S3C_RTC if RTC_CLASS diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 90c5cf4856e1..e6d4abadacd8 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -91,7 +91,6 @@ config ARCH_BRCMSTB config ARCH_EXYNOS bool "ARMv8 based Samsung Exynos SoC family" - select COMMON_CLK_SAMSUNG select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS select EXYNOS_PMU select HAVE_S3C_RTC if RTC_CLASS diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index 0441c4f73ac9..f987d386979d 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only # Recent Exynos platforms should just select COMMON_CLK_SAMSUNG: config COMMON_CLK_SAMSUNG - bool "Samsung Exynos clock controller support" if COMPILE_TEST + tristate "Samsung Exynos clock controller support" + default y if ARCH_EXYNOS || ARCH_S5PV210 || ARCH_S3C64XX select S3C64XX_COMMON_CLK if ARM && ARCH_S3C64XX select S5PV210_COMMON_CLK if ARM && ARCH_S5PV210 select EXYNOS_3250_COMMON_CLK if ARM && SOC_EXYNOS3250 @@ -70,7 +71,7 @@ config EXYNOS_5420_COMMON_CLK Exynos5420 SoCs. Choose Y here only if you build for this SoC. config EXYNOS_ARM64_COMMON_CLK - bool "Samsung Exynos ARMv8-family clock controller support" if COMPILE_TEST + tristate "Samsung Exynos ARMv8-family clock controller support" depends on COMMON_CLK_SAMSUNG config EXYNOS_AUDSS_CLK_CON
This sets the COMMON_CLK_SAMSUNG and EXYNOS_ARM64_COMMON_CLK drivers as tristate so that we can compile them as modules. Signed-off-by: Will McVicker <willmcvicker@google.com> --- arch/arm/mach-exynos/Kconfig | 1 - arch/arm/mach-s3c/Kconfig.s3c64xx | 1 - arch/arm/mach-s5pv210/Kconfig | 1 - arch/arm64/Kconfig.platforms | 1 - drivers/clk/samsung/Kconfig | 5 +++-- 5 files changed, 3 insertions(+), 6 deletions(-)