diff mbox series

[3/3] arm64: dts: exynos: add minimal support for exynosautov9 sadk board

Message ID 20211007120855.56555-4-chanho61.park@samsung.com (mailing list archive)
State Superseded
Headers show
Series add initial support for exynosautov9 | expand

Commit Message

Chanho Park Oct. 7, 2021, 12:08 p.m. UTC 
SADK(Samsung Automotive Development Kit) is the development kit to
evaluate Exynos Auto v9 SoC. It has 16GB LPDDR4 DRAM and two
256GB Samsung UFS. This patch enables only serial console and ufs0
device.

Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
 .../bindings/arm/samsung/samsung-boards.yaml  |  6 +++
 .../boot/dts/exynos/exynosautov9-sadk.dts     | 52 +++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts

Comments

Krzysztof Kozlowski Oct. 7, 2021, 6:30 p.m. UTC | #1 
On 07/10/2021 14:08, Chanho Park wrote:
> SADK(Samsung Automotive Development Kit) is the development kit to
> evaluate Exynos Auto v9 SoC. It has 16GB LPDDR4 DRAM and two
> 256GB Samsung UFS. This patch enables only serial console and ufs0
> device.
> 
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>  .../bindings/arm/samsung/samsung-boards.yaml  |  6 +++
>  .../boot/dts/exynos/exynosautov9-sadk.dts     | 52 +++++++++++++++++++

You need also Makefile entry.

>  2 files changed, 58 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> index 0796f0c87727..2147e664d5bc 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> @@ -199,6 +199,12 @@ properties:
>                - samsung,exynos7-espresso        # Samsung Exynos7 Espresso
>            - const: samsung,exynos7
>  
> +      - description: Exynos Auto v9 based boards
> +        items:
> +          - enum:
> +              - samsung,samsung,exynosautov9-sadk   # Samsung Exynos Auto v9 SADK

Double samsung.

> +          - const: samsung,exynosautov9
> +
>  required:
>    - compatible
>  
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> new file mode 100644
> index 000000000000..e59ef39a368f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Samsung ExynosAutov9 SADK board device tree source

Any Copyrights? Not needed, just mentioning...

> + */
> +
> +/dts-v1/;
> +#include "exynosautov9.dtsi"

Include gpio.h here, because it is used. Probably you can also remove it
from dtsi - I did not see it being used in there.

> +
> +/ {
> +	model = "Samsung ExynosAutov9 SADK board";
> +	compatible = "samsung,exynosautov9-sadk", "samsung,exynosautov9";
> +
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &serial_0;
> +	};
> +
> +	chosen {
> +		stdout-path = &serial_0;
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x80000000 0x0 0x77000000>,
> +		      <0x8 0x80000000 0x1 0x7ba00000>,
> +		      <0xa 0x00000000 0x2 0x00000000>;
> +	};
> +
> +	ufs_0_fixed_vcc: fixedregulator@0 {

Node name: "regulator" or "regulator-0" if you think you will have more
of them.

> +		compatible = "regulator-fixed";
> +		regulator-name = "ufs-vcc";
> +		gpio = <&gpq0 1 GPIO_ACTIVE_HIGH>;
> +		regulator-boot-on;
> +		enable-active-high;
> +	};
> +};
> +
> +&serial_0 {
> +	status = "okay";
> +};
> +
> +&ufs_0_phy {
> +	status = "okay";
> +};
> +
> +&ufs_0 {
> +	status = "okay";
> +	vcc-supply = <&ufs_0_fixed_vcc>;
> +	vcc-fixed-regulator;
> +};
> 


Best regards,
Krzysztof
Chanho Park Oct. 8, 2021, 12:52 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Sent: Friday, October 8, 2021 3:31 AM
> To: Chanho Park <chanho61.park@samsung.com>; Rob Herring
> <robh+dt@kernel.org>; Linus Walleij <linus.walleij@linaro.org>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>; Sylwester Nawrocki
> <s.nawrocki@samsung.com>; linux-samsung-soc@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 3/3] arm64: dts: exynos: add minimal support for
> exynosautov9 sadk board
> 
> On 07/10/2021 14:08, Chanho Park wrote:
> > SADK(Samsung Automotive Development Kit) is the development kit to
> > evaluate Exynos Auto v9 SoC. It has 16GB LPDDR4 DRAM and two 256GB
> > Samsung UFS. This patch enables only serial console and ufs0 device.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  .../bindings/arm/samsung/samsung-boards.yaml  |  6 +++
> >  .../boot/dts/exynos/exynosautov9-sadk.dts     | 52 +++++++++++++++++++
> 
> You need also Makefile entry.

I missed this because I'm building the dtb with the command line parameter. I'll add this.

> 
> >  2 files changed, 58 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> > b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> > index 0796f0c87727..2147e664d5bc 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yam
> > +++ l
> > @@ -199,6 +199,12 @@ properties:
> >                - samsung,exynos7-espresso        # Samsung Exynos7 Espresso
> >            - const: samsung,exynos7
> >
> > +      - description: Exynos Auto v9 based boards
> > +        items:
> > +          - enum:
> > +              - samsung,samsung,exynosautov9-sadk   # Samsung Exynos Auto
> v9 SADK
> 
> Double samsung.

Typo. I'll remove it.

> 
> > +          - const: samsung,exynosautov9
> > +
> >  required:
> >    - compatible
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > new file mode 100644
> > index 000000000000..e59ef39a368f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > @@ -0,0 +1,52 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Samsung ExynosAutov9 SADK board device tree source
> 
> Any Copyrights? Not needed, just mentioning...

Will add it.

> 
> > + */
> > +
> > +/dts-v1/;
> > +#include "exynosautov9.dtsi"
> 
> Include gpio.h here, because it is used. Probably you can also remove it
> from dtsi - I did not see it being used in there.

Okay. I'll move the inclusion from soc dtsi.

> 
> > +
> > +/ {
> > +	model = "Samsung ExynosAutov9 SADK board";
> > +	compatible = "samsung,exynosautov9-sadk", "samsung,exynosautov9";
> > +
> > +	#address-cells = <2>;
> > +	#size-cells = <2>;
> > +
> > +	aliases {
> > +		serial0 = &serial_0;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = &serial_0;
> > +	};
> > +
> > +	memory@80000000 {
> > +		device_type = "memory";
> > +		reg = <0x0 0x80000000 0x0 0x77000000>,
> > +		      <0x8 0x80000000 0x1 0x7ba00000>,
> > +		      <0xa 0x00000000 0x2 0x00000000>;
> > +	};
> > +
> > +	ufs_0_fixed_vcc: fixedregulator@0 {
> 
> Node name: "regulator" or "regulator-0" if you think you will have more of
> them.

I need one more gpio regulator for ufs_1. So, I'll use regulator-0 for this.

Best Regards,
Chanho Park
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
index 0796f0c87727..2147e664d5bc 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
@@ -199,6 +199,12 @@  properties:
               - samsung,exynos7-espresso        # Samsung Exynos7 Espresso
           - const: samsung,exynos7
 
+      - description: Exynos Auto v9 based boards
+        items:
+          - enum:
+              - samsung,samsung,exynosautov9-sadk   # Samsung Exynos Auto v9 SADK
+          - const: samsung,exynosautov9
+
 required:
   - compatible
 
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
new file mode 100644
index 000000000000..e59ef39a368f
--- /dev/null
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
@@ -0,0 +1,52 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Samsung ExynosAutov9 SADK board device tree source
+ */
+
+/dts-v1/;
+#include "exynosautov9.dtsi"
+
+/ {
+	model = "Samsung ExynosAutov9 SADK board";
+	compatible = "samsung,exynosautov9-sadk", "samsung,exynosautov9";
+
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	aliases {
+		serial0 = &serial_0;
+	};
+
+	chosen {
+		stdout-path = &serial_0;
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x0 0x80000000 0x0 0x77000000>,
+		      <0x8 0x80000000 0x1 0x7ba00000>,
+		      <0xa 0x00000000 0x2 0x00000000>;
+	};
+
+	ufs_0_fixed_vcc: fixedregulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "ufs-vcc";
+		gpio = <&gpq0 1 GPIO_ACTIVE_HIGH>;
+		regulator-boot-on;
+		enable-active-high;
+	};
+};
+
+&serial_0 {
+	status = "okay";
+};
+
+&ufs_0_phy {
+	status = "okay";
+};
+
+&ufs_0 {
+	status = "okay";
+	vcc-supply = <&ufs_0_fixed_vcc>;
+	vcc-fixed-regulator;
+};