diff mbox series

[2/2] arm64: defconfig: Enable Samsung I2C driver

Message ID 20211108134901.20490-2-semen.protsenko@linaro.org (mailing list archive)
State New
Headers show
Series [1/2] arm: samsung: Remove HAVE_S3C2410_I2C and use direct dependencies | expand

Commit Message

Sam Protsenko Nov. 8, 2021, 1:49 p.m. UTC
i2c-s3c2410 driver is needed for some arm64 Exynos SoCs, e.g. Exynos850.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Nov. 8, 2021, 2:18 p.m. UTC | #1
On 08/11/2021 14:49, Sam Protsenko wrote:
> i2c-s3c2410 driver is needed for some arm64 Exynos SoCs, e.g. Exynos850.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)

Hm, that's a little bit unexpected. I thought you will be also using the
HSI2C driver (where Jaewon is adding USI support).

Best regards,
Krzysztof
Sam Protsenko Nov. 8, 2021, 3:12 p.m. UTC | #2
On Mon, 8 Nov 2021 at 16:18, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 08/11/2021 14:49, Sam Protsenko wrote:
> > i2c-s3c2410 driver is needed for some arm64 Exynos SoCs, e.g. Exynos850.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
>
> Hm, that's a little bit unexpected. I thought you will be also using the
> HSI2C driver (where Jaewon is adding USI support).
>

Thought you'd ask :) Exynos850 has both I2C and HSI2C blocks:
  - I2C is a regular I2C, and uses s3c2410-i2c driver
  - whilst HSI2C is a high-speed I2C (used for example for cameras),
and uses exynos5-hsi2c driver

I'll look into HSI2C enablement on Exynos850 soon as well, so Jaewon's
patches might be helpful for my case too -- didn't check that yet.

> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 545197bc0501..7c6a3b91e55d 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -461,6 +461,7 @@  CONFIG_I2C_QCOM_CCI=m
 CONFIG_I2C_QCOM_GENI=m
 CONFIG_I2C_QUP=y
 CONFIG_I2C_RK3X=y
+CONFIG_I2C_S3C2410=y
 CONFIG_I2C_SH_MOBILE=y
 CONFIG_I2C_TEGRA=y
 CONFIG_I2C_UNIPHIER_F=y