| Message ID | 20211215160906.17451-2-semen.protsenko@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: exynos: Add E850-96 board support | expand |
On 15/12/2021 17:09, Sam Protsenko wrote: > System Register is used to configure system behavior, like USI protocol, > etc. SYSREG clocks should be provided to corresponding syscon nodes, to > make it possible to modify SYSREG registers. > > While at it, add also missing PMU and GPIO clocks, which looks necessary > and might be needed for corresponding Exynos850 features soon. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > include/dt-bindings/clock/exynos850.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On 12/16/21 1:09 AM, Sam Protsenko wrote: > System Register is used to configure system behavior, like USI protocol, > etc. SYSREG clocks should be provided to corresponding syscon nodes, to > make it possible to modify SYSREG registers. > > While at it, add also missing PMU and GPIO clocks, which looks necessary > and might be needed for corresponding Exynos850 features soon. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > include/dt-bindings/clock/exynos850.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/include/dt-bindings/clock/exynos850.h b/include/dt-bindings/clock/exynos850.h > index 8aa5e82af0d3..0b6a3c6a7c90 100644 > --- a/include/dt-bindings/clock/exynos850.h > +++ b/include/dt-bindings/clock/exynos850.h > @@ -82,7 +82,10 @@ > #define CLK_GOUT_I3C_PCLK 19 > #define CLK_GOUT_I3C_SCLK 20 > #define CLK_GOUT_SPEEDY_PCLK 21 > -#define APM_NR_CLK 22 > +#define CLK_GOUT_GPIO_ALIVE_PCLK 22 > +#define CLK_GOUT_PMU_ALIVE_PCLK 23 > +#define CLK_GOUT_SYSREG_APM_PCLK 24 > +#define APM_NR_CLK 25 > > /* CMU_CMGP */ > #define CLK_RCO_CMGP 1 > @@ -99,7 +102,8 @@ > #define CLK_GOUT_CMGP_USI0_PCLK 12 > #define CLK_GOUT_CMGP_USI1_IPCLK 13 > #define CLK_GOUT_CMGP_USI1_PCLK 14 > -#define CMGP_NR_CLK 15 > +#define CLK_GOUT_SYSREG_CMGP_PCLK 15 > +#define CMGP_NR_CLK 16 > > /* CMU_HSI */ > #define CLK_MOUT_HSI_BUS_USER 1 > @@ -167,7 +171,9 @@ > #define CLK_GOUT_MMC_EMBD_SDCLKIN 10 > #define CLK_GOUT_SSS_ACLK 11 > #define CLK_GOUT_SSS_PCLK 12 > -#define CORE_NR_CLK 13 > +#define CLK_GOUT_GPIO_CORE_PCLK 13 > +#define CLK_GOUT_SYSREG_CORE_PCLK 14 > +#define CORE_NR_CLK 15 > > /* CMU_DPU */ > #define CLK_MOUT_DPU_USER 1 > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
On Wed, 15 Dec 2021 18:09:00 +0200, Sam Protsenko wrote: > System Register is used to configure system behavior, like USI protocol, > etc. SYSREG clocks should be provided to corresponding syscon nodes, to > make it possible to modify SYSREG registers. > > While at it, add also missing PMU and GPIO clocks, which looks necessary > and might be needed for corresponding Exynos850 features soon. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > include/dt-bindings/clock/exynos850.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Thu, 16 Dec 2021 at 19:48, Rob Herring <robh@kernel.org> wrote: > > On Wed, 15 Dec 2021 18:09:00 +0200, Sam Protsenko wrote: > > System Register is used to configure system behavior, like USI protocol, > > etc. SYSREG clocks should be provided to corresponding syscon nodes, to > > make it possible to modify SYSREG registers. > > > > While at it, add also missing PMU and GPIO clocks, which looks necessary > > and might be needed for corresponding Exynos850 features soon. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > include/dt-bindings/clock/exynos850.h | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > No malice intended, just forgot to do so, sorry. Already added all missing tags, will be present in v2 (gonna send it soon).
diff --git a/include/dt-bindings/clock/exynos850.h b/include/dt-bindings/clock/exynos850.h index 8aa5e82af0d3..0b6a3c6a7c90 100644 --- a/include/dt-bindings/clock/exynos850.h +++ b/include/dt-bindings/clock/exynos850.h @@ -82,7 +82,10 @@ #define CLK_GOUT_I3C_PCLK 19 #define CLK_GOUT_I3C_SCLK 20 #define CLK_GOUT_SPEEDY_PCLK 21 -#define APM_NR_CLK 22 +#define CLK_GOUT_GPIO_ALIVE_PCLK 22 +#define CLK_GOUT_PMU_ALIVE_PCLK 23 +#define CLK_GOUT_SYSREG_APM_PCLK 24 +#define APM_NR_CLK 25 /* CMU_CMGP */ #define CLK_RCO_CMGP 1 @@ -99,7 +102,8 @@ #define CLK_GOUT_CMGP_USI0_PCLK 12 #define CLK_GOUT_CMGP_USI1_IPCLK 13 #define CLK_GOUT_CMGP_USI1_PCLK 14 -#define CMGP_NR_CLK 15 +#define CLK_GOUT_SYSREG_CMGP_PCLK 15 +#define CMGP_NR_CLK 16 /* CMU_HSI */ #define CLK_MOUT_HSI_BUS_USER 1 @@ -167,7 +171,9 @@ #define CLK_GOUT_MMC_EMBD_SDCLKIN 10 #define CLK_GOUT_SSS_ACLK 11 #define CLK_GOUT_SSS_PCLK 12 -#define CORE_NR_CLK 13 +#define CLK_GOUT_GPIO_CORE_PCLK 13 +#define CLK_GOUT_SYSREG_CORE_PCLK 14 +#define CORE_NR_CLK 15 /* CMU_DPU */ #define CLK_MOUT_DPU_USER 1
System Register is used to configure system behavior, like USI protocol, etc. SYSREG clocks should be provided to corresponding syscon nodes, to make it possible to modify SYSREG registers. While at it, add also missing PMU and GPIO clocks, which looks necessary and might be needed for corresponding Exynos850 features soon. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- include/dt-bindings/clock/exynos850.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)