| Message ID | 20211230195325.328220-2-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [RFT,1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 | expand |
On 30/12/2021 20:53, Krzysztof Kozlowski wrote: > Each pin configuration in pin controller should be a node with > "samsung,pins" and other similar properties. However the macro PIN() > (used for initial/sleep states) defines entire node, so PCIe WLAN pin > configuration node was ignored. > > Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > This patch is not correct, because the driver/bindings allow and work with such DTS. Please ignore. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index cbcc01a66aab..c5054c7a9c03 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -1104,8 +1104,11 @@ &pinctrl_ese { pinctrl-names = "default"; pinctrl-0 = <&initial_ese>; - pcie_wlanen: pcie-wlanen { - PIN(INPUT, gpj2-0, UP, FAST_SR4); + pcie_wlanen: pcie-wlanen-pins { + samsung,pins = "gpj2-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_UP>; + samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR4>; }; initial_ese: initial-state {
Each pin configuration in pin controller should be a node with "samsung,pins" and other similar properties. However the macro PIN() (used for initial/sleep states) defines entire node, so PCIe WLAN pin configuration node was ignored. Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards") Cc: <stable@vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)