| Message ID | 20220129175332.298666-4-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/5] arm64: dts: exynos: align pl330 node name with dtschema | expand |
On Sat, 29 Jan 2022 18:53:31 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos5433 LPASS bindings to DT schema format. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 ----------- > .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++ > 2 files changed, 119 insertions(+), 72 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt > create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml: audio-subsystem@11400000: serial@11460000:compatible:0: 'samsung,exynos5433-uart' is not one of ['apple,s5l-uart', 'samsung,s3c2410-uart', 'samsung,s3c2412-uart', 'samsung,s3c2440-uart', 'samsung,s3c6400-uart', 'samsung,s5pv210-uart', 'samsung,exynos4210-uart', 'samsung,exynos850-uart'] From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml:0:0: /example-0/audio-subsystem@11400000/serial@11460000: failed to match any schema with compatible: ['samsung,exynos5433-uart'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1586234 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 30/01/2022 01:22, Rob Herring wrote: > On Sat, 29 Jan 2022 18:53:31 +0100, Krzysztof Kozlowski wrote: >> Convert the Exynos5433 LPASS bindings to DT schema format. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 ----------- >> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++ >> 2 files changed, 119 insertions(+), 72 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml: audio-subsystem@11400000: serial@11460000:compatible:0: 'samsung,exynos5433-uart' is not one of ['apple,s5l-uart', 'samsung,s3c2410-uart', 'samsung,s3c2412-uart', 'samsung,s3c2440-uart', 'samsung,s3c6400-uart', 'samsung,s5pv210-uart', 'samsung,exynos4210-uart', 'samsung,exynos850-uart'] > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml:0:0: /example-0/audio-subsystem@11400000/serial@11460000: failed to match any schema with compatible: ['samsung,exynos5433-uart'] > This is false positive or rather my patch-ordering issue. I fixed it up in patch 5/5 of this series. Best regards, Krzysztof
On Sat, Jan 29, 2022 at 06:53:31PM +0100, Krzysztof Kozlowski wrote: > Convert the Exynos5433 LPASS bindings to DT schema format. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 ----------- > .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++ > 2 files changed, 119 insertions(+), 72 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt > create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt > deleted file mode 100644 > index 30ea27c3936d..000000000000 > --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt > +++ /dev/null > @@ -1,72 +0,0 @@ > -Samsung Exynos SoC Low Power Audio Subsystem (LPASS) > - > -Required properties: > - > - - compatible : "samsung,exynos5433-lpass" > - - reg : should contain the LPASS top SFR region location > - and size > - - clock-names : should contain following required clocks: "sfr0_ctrl" > - - clocks : should contain clock specifiers of all clocks, which > - input names have been specified in clock-names > - property, in same order. > - - #address-cells : should be 1 > - - #size-cells : should be 1 > - - ranges : must be present > - > -Each IP block of the Low Power Audio Subsystem should be specified as > -an optional sub-node. For "samsung,exynos5433-lpass" compatible this includes: > -UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, VIC, WDT 0...1 devices. > - > -Bindings of the sub-nodes are described in: > - ../serial/samsung_uart.yaml > - ../sound/samsung-i2s.txt > - ../dma/arm-pl330.txt > - > - > -Example: > - > -audio-subsystem { > - compatible = "samsung,exynos5433-lpass"; > - reg = <0x11400000 0x100>, <0x11500000 0x08>; > - clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; > - clock-names = "sfr0_ctrl"; > - #address-cells = <1>; > - #size-cells = <1>; > - ranges; > - > - adma: adma@11420000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x11420000 0x1000>; > - interrupts = <0 73 0>; > - clocks = <&cmu_aud CLK_ACLK_DMAC>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > - > - i2s0: i2s0@11440000 { > - compatible = "samsung,exynos7-i2s"; > - reg = <0x11440000 0x100>; > - dmas = <&adma 0 &adma 2>; > - dma-names = "tx", "rx"; > - interrupts = <0 70 0>; > - clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, > - <&cmu_aud CLK_SCLK_AUD_I2S>, > - <&cmu_aud CLK_SCLK_I2S_BCLK>; > - clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; > - pinctrl-names = "default"; > - pinctrl-0 = <&i2s0_bus>; > - }; > - > - serial_3: serial@11460000 { > - compatible = "samsung,exynos5433-uart"; > - reg = <0x11460000 0x100>; > - interrupts = <0 67 0>; > - clocks = <&cmu_aud CLK_PCLK_AUD_UART>, > - <&cmu_aud CLK_SCLK_AUD_UART>; > - clock-names = "uart", "clk_uart_baud0"; > - pinctrl-names = "default"; > - pinctrl-0 = <&uart_aud_bus>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > new file mode 100644 > index 000000000000..96ef6113c8bf > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > @@ -0,0 +1,119 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/samsung,exynos5433-lpass.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC Low Power Audio Subsystem (LPASS) > + > +maintainers: > + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > + > +properties: > + compatible: > + const: samsung,exynos5433-lpass > + > + '#address-cells': > + const: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: sfr0_ctrl > + > + power-domains: > + maxItems: 1 > + > + ranges: true > + > + reg: > + minItems: 2 > + maxItems: 2 > + > + '#size-cells': > + const: 1 > + > +patternProperties: > + "^dma-controller@[0-9a-f]+$": > + $ref: /schemas/dma/arm,pl330.yaml > + > + "^i2s@[0-9a-f]+$": > + $ref: /schemas/sound/samsung-i2s.yaml > + > + "^serial@[0-9a-f]+$": > + $ref: /schemas/serial/samsung_uart.yaml > + > +required: > + - compatible > + - '#address-cells' > + - clocks > + - clock-names > + - ranges > + - reg > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/exynos5433.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + audio-subsystem@11400000 { > + compatible = "samsung,exynos5433-lpass"; > + reg = <0x11400000 0x100>, <0x11500000 0x08>; > + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; > + clock-names = "sfr0_ctrl"; > + power-domains = <&pd_aud>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + dma-controller@11420000 { > + compatible = "arm,pl330", "arm,primecell"; > + reg = <0x11420000 0x1000>; > + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cmu_aud CLK_ACLK_DMAC>; > + clock-names = "apb_pclk"; > + #dma-cells = <1>; > + #dma-channels = <8>; > + #dma-requests = <32>; > + power-domains = <&pd_aud>; > + }; > + > + i2s@11440000 { > + compatible = "samsung,exynos7-i2s"; > + reg = <0x11440000 0x100>; > + dmas = <&adma 0>, <&adma 2>; > + dma-names = "tx", "rx"; > + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, > + <&cmu_aud CLK_SCLK_AUD_I2S>, > + <&cmu_aud CLK_SCLK_I2S_BCLK>; > + clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; > + #clock-cells = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2s0_bus>; > + power-domains = <&pd_aud>; > + #sound-dai-cells = <1>; > + status = "disabled"; Drop 'status'. > + }; > + > + serial@11460000 { > + compatible = "samsung,exynos5433-uart"; > + reg = <0x11460000 0x100>; > + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cmu_aud CLK_PCLK_AUD_UART>, > + <&cmu_aud CLK_SCLK_AUD_UART>; > + clock-names = "uart", "clk_uart_baud0"; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart_aud_bus>; > + power-domains = <&pd_aud>; > + status = "disabled"; Ditto. With that, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt deleted file mode 100644 index 30ea27c3936d..000000000000 --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt +++ /dev/null @@ -1,72 +0,0 @@ -Samsung Exynos SoC Low Power Audio Subsystem (LPASS) - -Required properties: - - - compatible : "samsung,exynos5433-lpass" - - reg : should contain the LPASS top SFR region location - and size - - clock-names : should contain following required clocks: "sfr0_ctrl" - - clocks : should contain clock specifiers of all clocks, which - input names have been specified in clock-names - property, in same order. - - #address-cells : should be 1 - - #size-cells : should be 1 - - ranges : must be present - -Each IP block of the Low Power Audio Subsystem should be specified as -an optional sub-node. For "samsung,exynos5433-lpass" compatible this includes: -UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, VIC, WDT 0...1 devices. - -Bindings of the sub-nodes are described in: - ../serial/samsung_uart.yaml - ../sound/samsung-i2s.txt - ../dma/arm-pl330.txt - - -Example: - -audio-subsystem { - compatible = "samsung,exynos5433-lpass"; - reg = <0x11400000 0x100>, <0x11500000 0x08>; - clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; - clock-names = "sfr0_ctrl"; - #address-cells = <1>; - #size-cells = <1>; - ranges; - - adma: adma@11420000 { - compatible = "arm,pl330", "arm,primecell"; - reg = <0x11420000 0x1000>; - interrupts = <0 73 0>; - clocks = <&cmu_aud CLK_ACLK_DMAC>; - clock-names = "apb_pclk"; - #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; - }; - - i2s0: i2s0@11440000 { - compatible = "samsung,exynos7-i2s"; - reg = <0x11440000 0x100>; - dmas = <&adma 0 &adma 2>; - dma-names = "tx", "rx"; - interrupts = <0 70 0>; - clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, - <&cmu_aud CLK_SCLK_AUD_I2S>, - <&cmu_aud CLK_SCLK_I2S_BCLK>; - clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; - pinctrl-names = "default"; - pinctrl-0 = <&i2s0_bus>; - }; - - serial_3: serial@11460000 { - compatible = "samsung,exynos5433-uart"; - reg = <0x11460000 0x100>; - interrupts = <0 67 0>; - clocks = <&cmu_aud CLK_PCLK_AUD_UART>, - <&cmu_aud CLK_SCLK_AUD_UART>; - clock-names = "uart", "clk_uart_baud0"; - pinctrl-names = "default"; - pinctrl-0 = <&uart_aud_bus>; - }; - }; diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml new file mode 100644 index 000000000000..96ef6113c8bf --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml @@ -0,0 +1,119 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/samsung,exynos5433-lpass.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Exynos SoC Low Power Audio Subsystem (LPASS) + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> + - Sylwester Nawrocki <s.nawrocki@samsung.com> + +properties: + compatible: + const: samsung,exynos5433-lpass + + '#address-cells': + const: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: sfr0_ctrl + + power-domains: + maxItems: 1 + + ranges: true + + reg: + minItems: 2 + maxItems: 2 + + '#size-cells': + const: 1 + +patternProperties: + "^dma-controller@[0-9a-f]+$": + $ref: /schemas/dma/arm,pl330.yaml + + "^i2s@[0-9a-f]+$": + $ref: /schemas/sound/samsung-i2s.yaml + + "^serial@[0-9a-f]+$": + $ref: /schemas/serial/samsung_uart.yaml + +required: + - compatible + - '#address-cells' + - clocks + - clock-names + - ranges + - reg + - '#size-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/exynos5433.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + audio-subsystem@11400000 { + compatible = "samsung,exynos5433-lpass"; + reg = <0x11400000 0x100>, <0x11500000 0x08>; + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; + clock-names = "sfr0_ctrl"; + power-domains = <&pd_aud>; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + dma-controller@11420000 { + compatible = "arm,pl330", "arm,primecell"; + reg = <0x11420000 0x1000>; + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_aud CLK_ACLK_DMAC>; + clock-names = "apb_pclk"; + #dma-cells = <1>; + #dma-channels = <8>; + #dma-requests = <32>; + power-domains = <&pd_aud>; + }; + + i2s@11440000 { + compatible = "samsung,exynos7-i2s"; + reg = <0x11440000 0x100>; + dmas = <&adma 0>, <&adma 2>; + dma-names = "tx", "rx"; + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, + <&cmu_aud CLK_SCLK_AUD_I2S>, + <&cmu_aud CLK_SCLK_I2S_BCLK>; + clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; + #clock-cells = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&i2s0_bus>; + power-domains = <&pd_aud>; + #sound-dai-cells = <1>; + status = "disabled"; + }; + + serial@11460000 { + compatible = "samsung,exynos5433-uart"; + reg = <0x11460000 0x100>; + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_aud CLK_PCLK_AUD_UART>, + <&cmu_aud CLK_SCLK_AUD_UART>; + clock-names = "uart", "clk_uart_baud0"; + pinctrl-names = "default"; + pinctrl-0 = <&uart_aud_bus>; + power-domains = <&pd_aud>; + status = "disabled"; + }; + };
Convert the Exynos5433 LPASS bindings to DT schema format. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 ----------- .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++ 2 files changed, 119 insertions(+), 72 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml