| Message ID | 20221107155825.1644604-23-pierre.gondois@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bf2ae716bc4a442e6e8270c18fd29441c031ace8 |
| Headers | show |
| Series | Update cache properties for arm64 DTS | expand |
On 11/7/22 18:56, Krzysztof Kozlowski wrote: > On 07/11/2022 16:57, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> The 'cache-unified' property should be present if one of the >> properties for unified cache is present ('cache-size', ...). > > No. This was applied and subject has wrong prefix. > > Trim your CC list because it's impossible to reply (without manually > removing people). > > Best regards, > Krzysztof > Yes, this patch must be dropped. I will do as you suggested in the cover letter, Sorry for the trouble, Regards, Pierre
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi index f35bc5a288c2..d58d47618c95 100644 --- a/arch/arm64/boot/dts/tesla/fsd.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi @@ -281,6 +281,8 @@ cpucl2_3: cpu@203 { cpucl_l2: l2-cache0 { compatible = "cache"; + cache-level = <2>; + cache-unified; cache-size = <0x400000>; cache-line-size = <64>; cache-sets = <4096>;
The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...). Update the Device Trees accordingly. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> --- arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++ 1 file changed, 2 insertions(+)