diff mbox series

[7/7] ARM: dts: exynos: move I2C10 out of soc node on Arndale

Message ID 20230207210020.677007-7-krzysztof.kozlowski@linaro.org (mailing list archive)
State Under Review
Commit 27dfcb622b59cbce2c7f55cd87f06d2cdf20d5eb
Headers show
Series [1/7] ARM: dts: exynos: Remove empty camera pinctrl configuration in Trats | expand

Commit Message

Krzysztof Kozlowski Feb. 7, 2023, 9 p.m. UTC 
I2C10 is represented as i2c-gpio device, thus it is not really a part of
soc MMIO bus:

  exynos5250-arndale.dtb: soc: i2c-10: {'pinctrl-names': ['default'], ... } should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts | 28 +++++++++++-------------
 1 file changed, 13 insertions(+), 15 deletions(-)

Comments

Krzysztof Kozlowski Feb. 9, 2023, 11:10 a.m. UTC | #1 
On Tue, 7 Feb 2023 22:00:20 +0100, Krzysztof Kozlowski wrote:
> I2C10 is represented as i2c-gpio device, thus it is not really a part of
> soc MMIO bus:
> 
>   exynos5250-arndale.dtb: soc: i2c-10: {'pinctrl-names': ['default'], ... } should not be valid under {'type': 'object'}
> 
> 

Applied, thanks!

[7/7] ARM: dts: exynos: move I2C10 out of soc node on Arndale
      https://git.kernel.org/krzk/linux/c/27dfcb622b59cbce2c7f55cd87f06d2cdf20d5eb

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 305289ed06d8..56f08ca4762c 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -73,6 +73,19 @@  key-wakeup {
 		};
 	};
 
+	/*
+	 * For unknown reasons HDMI-DDC does not work with Exynos I2C
+	 * controllers. Lets use software I2C over GPIO pins as a workaround.
+	 */
+	i2c_ddc: i2c-10 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_gpio_bus>;
+		compatible = "i2c-gpio";
+		sda-gpios = <&gpa0 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+		scl-gpios = <&gpa0 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+		i2c-gpio,delay-us = <2>;
+	};
+
 	panel: panel {
 		compatible = "boe,hv070wsa-100";
 		power-supply = <&vcc_3v3_reg>;
@@ -615,21 +628,6 @@  &sata_phy_i2c {
 	status = "okay";
 };
 
-&soc {
-	/*
-	 * For unknown reasons HDMI-DDC does not work with Exynos I2C
-	 * controllers. Lets use software I2C over GPIO pins as a workaround.
-	 */
-	i2c_ddc: i2c-10 {
-		pinctrl-names = "default";
-		pinctrl-0 = <&i2c2_gpio_bus>;
-		compatible = "i2c-gpio";
-		sda-gpios = <&gpa0 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
-		scl-gpios = <&gpa0 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
-		i2c-gpio,delay-us = <2>;
-	};
-};
-
 &usbdrd {
 	vdd10-supply = <&ldo15_reg>;
 	vdd33-supply = <&ldo12_reg>;