diff mbox series

[13/16] PCI: samsung: Rename common functions to samsung

Message ID 20230214121333.1837-14-shradha.t@samsung.com (mailing list archive)
State New
Headers show
Series [01/16] dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe | expand

Commit Message

Shradha Todi Feb. 14, 2023, 12:13 p.m. UTC 
Use samsung instead of exynos for all common functions
like probe/remove/suspend/resume.

Suggested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Shradha Todi <shradha.t@samsung.com>
---
 drivers/pci/controller/dwc/pci-samsung.c | 42 ++++++++++++------------
 1 file changed, 21 insertions(+), 21 deletions(-)

Comments

Krzysztof Kozlowski Feb. 16, 2023, 11:09 a.m. UTC | #1 
On 14/02/2023 13:13, Shradha Todi wrote:
> Use samsung instead of exynos for all common functions
> like probe/remove/suspend/resume.
> 
> Suggested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> ---
>  drivers/pci/controller/dwc/pci-samsung.c | 42 ++++++++++++------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-samsung.c b/drivers/pci/controller/dwc/pci-samsung.c
> index 719d284e1552..dc8ec0b546fd 100644
> --- a/drivers/pci/controller/dwc/pci-samsung.c
> +++ b/drivers/pci/controller/dwc/pci-samsung.c
> @@ -60,7 +60,7 @@ struct samsung_pcie {
>  	struct regulator_bulk_data	supplies[2];
>  };
>  
> -static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
> +static int samsung_pcie_init_clk_resources(struct samsung_pcie *sp)

Same as before - I don't see here benefit.

>  {
>  	struct device *dev = sp->pci.dev;
>  	int ret;
> @@ -74,7 +74,7 @@ static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
>  	return clk_bulk_prepare_enable(sp->clk_cnt, sp->clks);
>  }
>  

(...)

>  
> -static struct platform_driver exynos_pcie_driver = {
> -	.probe		= exynos_pcie_probe,
> -	.remove		= __exit_p(exynos_pcie_remove),
> +static struct platform_driver samsung_pcie_driver = {
> +	.probe		= samsung_pcie_probe,
> +	.remove		= __exit_p(samsung_pcie_remove),
>  	.driver = {
> -		.name	= "exynos-pcie",
> -		.of_match_table = exynos_pcie_of_match,
> -		.pm		= &exynos_pcie_pm_ops,
> +		.name	= "samsung-pcie",

This "name" has some point... but I think it would break now all module
users.

> +		.of_match_table = samsung_pcie_of_match,
> +		.pm		= &samsung_pcie_pm_ops,
>  	},
>  };
> -module_platform_driver(exynos_pcie_driver);
> +module_platform_driver(samsung_pcie_driver);
>  MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(of, exynos_pcie_of_match);
> +MODULE_DEVICE_TABLE(of, samsung_pcie_of_match);

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pci-samsung.c b/drivers/pci/controller/dwc/pci-samsung.c
index 719d284e1552..dc8ec0b546fd 100644
--- a/drivers/pci/controller/dwc/pci-samsung.c
+++ b/drivers/pci/controller/dwc/pci-samsung.c
@@ -60,7 +60,7 @@  struct samsung_pcie {
 	struct regulator_bulk_data	supplies[2];
 };
 
-static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
+static int samsung_pcie_init_clk_resources(struct samsung_pcie *sp)
 {
 	struct device *dev = sp->pci.dev;
 	int ret;
@@ -74,7 +74,7 @@  static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
 	return clk_bulk_prepare_enable(sp->clk_cnt, sp->clks);
 }
 
-static void exynos_pcie_deinit_clk_resources(struct samsung_pcie *sp)
+static void samsung_pcie_deinit_clk_resources(struct samsung_pcie *sp)
 {
 	clk_bulk_disable_unprepare(sp->clk_cnt, sp->clks);
 }
@@ -297,7 +297,7 @@  static const struct dw_pcie_ops dw_pcie_ops = {
 	.start_link = exynos_pcie_start_link,
 };
 
-static int exynos_pcie_probe(struct platform_device *pdev)
+static int samsung_pcie_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct samsung_pcie *sp;
@@ -319,7 +319,7 @@  static int exynos_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(sp->appl_base))
 		return PTR_ERR(sp->appl_base);
 
-	ret = exynos_pcie_init_clk_resources(sp);
+	ret = samsung_pcie_init_clk_resources(sp);
 	if (ret < 0)
 		return ret;
 
@@ -345,12 +345,12 @@  static int exynos_pcie_probe(struct platform_device *pdev)
 fail_probe:
 	phy_exit(sp->phy);
 	regulator_bulk_disable(ARRAY_SIZE(sp->supplies), sp->supplies);
-	exynos_pcie_deinit_clk_resources(sp);
+	samsung_pcie_deinit_clk_resources(sp);
 
 	return ret;
 }
 
-static int __exit exynos_pcie_remove(struct platform_device *pdev)
+static int __exit samsung_pcie_remove(struct platform_device *pdev)
 {
 	struct samsung_pcie *sp = platform_get_drvdata(pdev);
 
@@ -358,13 +358,13 @@  static int __exit exynos_pcie_remove(struct platform_device *pdev)
 	exynos_pcie_assert_core_reset(sp);
 	phy_power_off(sp->phy);
 	phy_exit(sp->phy);
-	exynos_pcie_deinit_clk_resources(sp);
+	samsung_pcie_deinit_clk_resources(sp);
 	regulator_bulk_disable(ARRAY_SIZE(sp->supplies), sp->supplies);
 
 	return 0;
 }
 
-static int exynos_pcie_suspend_noirq(struct device *dev)
+static int samsung_pcie_suspend_noirq(struct device *dev)
 {
 	struct samsung_pcie *sp = dev_get_drvdata(dev);
 
@@ -376,7 +376,7 @@  static int exynos_pcie_suspend_noirq(struct device *dev)
 	return 0;
 }
 
-static int exynos_pcie_resume_noirq(struct device *dev)
+static int samsung_pcie_resume_noirq(struct device *dev)
 {
 	struct samsung_pcie *sp = dev_get_drvdata(dev);
 	struct dw_pcie *pci = &sp->pci;
@@ -394,25 +394,25 @@  static int exynos_pcie_resume_noirq(struct device *dev)
 	return dw_pcie_wait_for_link(pci);
 }
 
-static const struct dev_pm_ops exynos_pcie_pm_ops = {
-	NOIRQ_SYSTEM_SLEEP_PM_OPS(exynos_pcie_suspend_noirq,
-				  exynos_pcie_resume_noirq)
+static const struct dev_pm_ops samsung_pcie_pm_ops = {
+	NOIRQ_SYSTEM_SLEEP_PM_OPS(samsung_pcie_suspend_noirq,
+				  samsung_pcie_resume_noirq)
 };
 
-static const struct of_device_id exynos_pcie_of_match[] = {
+static const struct of_device_id samsung_pcie_of_match[] = {
 	{ .compatible = "samsung,exynos5433-pcie", },
 	{ },
 };
 
-static struct platform_driver exynos_pcie_driver = {
-	.probe		= exynos_pcie_probe,
-	.remove		= __exit_p(exynos_pcie_remove),
+static struct platform_driver samsung_pcie_driver = {
+	.probe		= samsung_pcie_probe,
+	.remove		= __exit_p(samsung_pcie_remove),
 	.driver = {
-		.name	= "exynos-pcie",
-		.of_match_table = exynos_pcie_of_match,
-		.pm		= &exynos_pcie_pm_ops,
+		.name	= "samsung-pcie",
+		.of_match_table = samsung_pcie_of_match,
+		.pm		= &samsung_pcie_pm_ops,
 	},
 };
-module_platform_driver(exynos_pcie_driver);
+module_platform_driver(samsung_pcie_driver);
 MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, exynos_pcie_of_match);
+MODULE_DEVICE_TABLE(of, samsung_pcie_of_match);