| Message ID | 20230310214435.275127-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd6a6893ac055dab9c21c39ef20293094d38045b |
| Headers | show |
| Series | [1/3] ufs: qcom: add __maybe_unused to OF ID table | expand |
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Saturday, March 11, 2023 3:15 AM > To: Alim Akhtar <alim.akhtar@samsung.com>; James E.J. Bottomley > <jejb@linux.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>; > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Manivannan Sadhasivam > <mani@kernel.org>; Andy Gross <agross@kernel.org>; Bjorn Andersson > <andersson@kernel.org>; Konrad Dybcio <konrad.dybcio@linaro.org>; linux- > scsi@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > msm@vger.kernel.org > Subject: [PATCH 2/3] ufs: exynos: drop of_match_ptr for ID table > > The driver can match only via the DT table so the table should be always used > and the of_match_ptr does not have any sense (this also allows ACPI matching > via PRP0001, even though it is not relevant here). > > drivers/ufs/host/ufs-exynos.c:1738:34: error: ‘exynos_ufs_of_match’ defined > but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/ufs/host/ufs-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index > 7c985fc38db1..0bf5390739e1 100644 > --- a/drivers/ufs/host/ufs-exynos.c > +++ b/drivers/ufs/host/ufs-exynos.c > @@ -1761,7 +1761,7 @@ static struct platform_driver exynos_ufs_pltform = { > .driver = { > .name = "exynos-ufshc", > .pm = &exynos_ufs_pm_ops, > - .of_match_table = of_match_ptr(exynos_ufs_of_match), > + .of_match_table = exynos_ufs_of_match, > }, > }; > module_platform_driver(exynos_ufs_pltform); > -- > 2.34.1
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 7c985fc38db1..0bf5390739e1 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1761,7 +1761,7 @@ static struct platform_driver exynos_ufs_pltform = { .driver = { .name = "exynos-ufshc", .pm = &exynos_ufs_pm_ops, - .of_match_table = of_match_ptr(exynos_ufs_of_match), + .of_match_table = exynos_ufs_of_match, }, }; module_platform_driver(exynos_ufs_pltform);
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). drivers/ufs/host/ufs-exynos.c:1738:34: error: ‘exynos_ufs_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/ufs/host/ufs-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)