| Message ID | 20230720172751.2918776-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] ARM: s5pv210: Explicitly include correct DT includes | expand |
On Thu, 20 Jul 2023 11:27:51 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > [...] Applied, thanks! [1/1] ARM: s5pv210: Explicitly include correct DT includes https://git.kernel.org/krzk/linux/c/3027df7e739c4f3768690bc59f022a0af8e6712c Best regards,
diff --git a/arch/arm/mach-s5pv210/s5pv210.c b/arch/arm/mach-s5pv210/s5pv210.c index a21ed3bb992a..7d4a10184160 100644 --- a/arch/arm/mach-s5pv210/s5pv210.c +++ b/arch/arm/mach-s5pv210/s5pv210.c @@ -7,7 +7,7 @@ // Tomasz Figa <t.figa@samsung.com> #include <linux/of_fdt.h> -#include <linux/of_platform.h> +#include <linux/platform_device.h> #include <asm/mach/arch.h> #include <asm/mach/map.h>
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <robh@kernel.org> --- v2: Add missing Sob --- arch/arm/mach-s5pv210/s5pv210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)