| Message ID | 20230722121719.150094-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/3] ARM: dts: samsung: exynos4x12: replace duplicate pmu node with phandle | expand |
On Sat, 22 Jul 2023 14:17:17 +0200, Krzysztof Kozlowski wrote: > Devicetree for the FIMC IS camera included duplicated PMU node as its > child. This is not a correct representation of the hardware. Mapping > the PMU (Power Management Unit) IO memory should be via syscon-like > phandle (samsung,pmu-syscon, already used for other drivers), not by > duplicating "pmu" Devicetree node inside the FIMC IS. > > The change is not compatible with older Linux kernel, which does not > parse samsung,pmu-syscon property. > > [...] Applied, thanks! [1/3] ARM: dts: samsung: exynos4x12: replace duplicate pmu node with phandle https://git.kernel.org/krzk/linux/c/797bf47d8a42792762cfc74dc84109d6d893ddf2 [2/3] ARM: dts: samsung: exynos4: fix camera unit addresses/ranges https://git.kernel.org/krzk/linux/c/ba2a45a48503665f7e8eeec51f8b40456566b0cd [3/3] ARM: dts: samsung: s5pv210: fix camera unit addresses/ranges https://git.kernel.org/krzk/linux/c/07e6a553c2f1d385edfc9185081dee442a9dd38d Best regards,
diff --git a/arch/arm/boot/dts/samsung/exynos4x12.dtsi b/arch/arm/boot/dts/samsung/exynos4x12.dtsi index 84c1db221c98..4524c1e6bb2f 100644 --- a/arch/arm/boot/dts/samsung/exynos4x12.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4x12.dtsi @@ -516,15 +516,12 @@ fimc_is: fimc-is@12000000 { iommus = <&sysmmu_fimc_isp>, <&sysmmu_fimc_drc>, <&sysmmu_fimc_fd>, <&sysmmu_fimc_mcuctl>; iommu-names = "isp", "drc", "fd", "mcuctl"; + samsung,pmu-syscon = <&pmu_system_controller>; #address-cells = <1>; #size-cells = <1>; ranges; status = "disabled"; - pmu@10020000 { - reg = <0x10020000 0x3000>; - }; - i2c1_isp: i2c-isp@12140000 { compatible = "samsung,exynos4212-i2c-isp"; reg = <0x12140000 0x100>;
Devicetree for the FIMC IS camera included duplicated PMU node as its child. This is not a correct representation of the hardware. Mapping the PMU (Power Management Unit) IO memory should be via syscon-like phandle (samsung,pmu-syscon, already used for other drivers), not by duplicating "pmu" Devicetree node inside the FIMC IS. The change is not compatible with older Linux kernel, which does not parse samsung,pmu-syscon property. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. None Depends on: https://lore.kernel.org/linux-devicetree/20230722115441.139628-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm/boot/dts/samsung/exynos4x12.dtsi | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)