| Message ID | 20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 36588ba3a3dfd3c453c711479efbe5deaad8d068 |
| Headers | show |
| Series | media: s5p-mfc: cleanups | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 24 December 2023 21:14 > To: Marek Szyprowski <m.szyprowski@samsung.com>; Andrzej Hajda > <andrzej.hajda@intel.com>; Mauro Carvalho Chehab > <mchehab@kernel.org> > Cc: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-fsd@tesla.coma; linux- > samsung-soc@vger.kernel.org; Smitha T Murthy > <smithatmurthy@gmail.com>; linux-arm-kernel@lists.infradead.org; linux- > media@vger.kernel.org; linux-kernel@vger.kernel.org; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> > Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops > > File-scope static variable "s5p_mfc_ops" is not read after assignment, thus it > can be dropped entirely. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c > b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c > index 673962301173..5ba791fa3676 100644 > --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c > +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c > @@ -14,18 +14,15 @@ > #include "s5p_mfc_opr_v5.h" > #include "s5p_mfc_opr_v6.h" > > -static struct s5p_mfc_hw_ops *s5p_mfc_ops; > - > void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev) { > if (IS_MFCV6_PLUS(dev)) { > - s5p_mfc_ops = s5p_mfc_init_hw_ops_v6(); > + dev->mfc_ops = s5p_mfc_init_hw_ops_v6(); > dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6; > } else { > - s5p_mfc_ops = s5p_mfc_init_hw_ops_v5(); > + dev->mfc_ops = s5p_mfc_init_hw_ops_v5(); > dev->warn_start = S5P_FIMV_ERR_WARNINGS_START; > } > - dev->mfc_ops = s5p_mfc_ops; > } > > void s5p_mfc_init_regs(struct s5p_mfc_dev *dev) > > -- > 2.34.1 Reviewed-by: Aakarsh Jain <aakarsh.jain@samsung.com> Thanks!
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c index 673962301173..5ba791fa3676 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c @@ -14,18 +14,15 @@ #include "s5p_mfc_opr_v5.h" #include "s5p_mfc_opr_v6.h" -static struct s5p_mfc_hw_ops *s5p_mfc_ops; - void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev) { if (IS_MFCV6_PLUS(dev)) { - s5p_mfc_ops = s5p_mfc_init_hw_ops_v6(); + dev->mfc_ops = s5p_mfc_init_hw_ops_v6(); dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6; } else { - s5p_mfc_ops = s5p_mfc_init_hw_ops_v5(); + dev->mfc_ops = s5p_mfc_init_hw_ops_v5(); dev->warn_start = S5P_FIMV_ERR_WARNINGS_START; } - dev->mfc_ops = s5p_mfc_ops; } void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
File-scope static variable "s5p_mfc_ops" is not read after assignment, thus it can be dropped entirely. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)