| Message ID | 20240101-tab3-display-fixes-v1-2-887ba4dbd16b@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 62b143b5ec4a14e1ae0dede5aabaf1832e3b0073 |
| Headers | show |
| Series | Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI | expand |
Hi Artur, On Mon, Jan 01, 2024 at 10:00:16PM +0100, Artur Weber wrote: > It turns out that I had misconfigured the device I was using the panel > with; the bus data polarity is not high for this panel, I had to change > the config on the display controller's side. > > Fix the panel config to properly reflect its accurate settings. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> I guess it deserves a Fixes tag: Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver") Best regards, Henrik Grimler > --- > drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > index ea5a85779382..f23d8832a1ad 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { > .off_func = s6d7aa0_lsl080al02_off, > .drm_mode = &s6d7aa0_lsl080al02_mode, > .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, > - .bus_flags = DRM_BUS_FLAG_DE_HIGH, > + .bus_flags = 0, > > .has_backlight = false, > .use_passwd3 = false, > > -- > 2.43.0 > >
On 1/1/2024 1:00 PM, Artur Weber wrote: > It turns out that I had misconfigured the device I was using the panel > with; the bus data polarity is not high for this panel, I had to change > the config on the display controller's side. > > Fix the panel config to properly reflect its accurate settings. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> Hi Artur, With Henrik's suggestion to add the Fixes tag, Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> Thanks, Jessica Zhang > --- > drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > index ea5a85779382..f23d8832a1ad 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c > @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { > .off_func = s6d7aa0_lsl080al02_off, > .drm_mode = &s6d7aa0_lsl080al02_mode, > .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, > - .bus_flags = DRM_BUS_FLAG_DE_HIGH, > + .bus_flags = 0, > > .has_backlight = false, > .use_passwd3 = false, > > -- > 2.43.0 >
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,
It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Signed-off-by: Artur Weber <aweber.kernel@gmail.com> --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)