| Message ID | 20240326103620.298298-3-tudor.ambarus@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: exynos: gs101: define all PERIC USI nodes | expand |
Hi Tudor, > -----Original Message----- > From: Tudor Ambarus <tudor.ambarus@linaro.org> > Sent: Tuesday, March 26, 2024 4:06 PM > To: peter.griffin@linaro.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org > Cc: alim.akhtar@samsung.com; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; andre.draszik@linaro.org; > willmcvicker@google.com; kernel-team@android.com; Tudor Ambarus > <tudor.ambarus@linaro.org> > Subject: [PATCH v2 2/4] arm64: dts: exynos: gs101: order pinctrl-* props > alphabetically > > Reverse pinctrl-* lines, first pinctrl-0 then pinctrl-names. Move the > pinctrl-* properties after clocks so that we keep alphabetic order and align > with the other similar definitions. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >
Hi Tudor, On Tue, 2024-03-26 at 10:36 +0000, Tudor Ambarus wrote: > Reverse pinctrl-* lines, first pinctrl-0 then pinctrl-names. Move the > pinctrl-* properties after clocks so that we keep alphabetic order and > align with the other similar definitions. Krzysztof had requested to change not just the DTSI but all instances for GS101 here: https://lore.kernel.org/all/98810c49-38e6-4402-bd47-05d8cbc99ef3@linaro.org/ Cheers, Andre'
On 3/26/24 11:13, André Draszik wrote: > Hi Tudor, > > On Tue, 2024-03-26 at 10:36 +0000, Tudor Ambarus wrote: >> Reverse pinctrl-* lines, first pinctrl-0 then pinctrl-names. Move the >> pinctrl-* properties after clocks so that we keep alphabetic order and >> align with the other similar definitions. > > Krzysztof had requested to change not just the DTSI but all instances for GS101 > here: > https://lore.kernel.org/all/98810c49-38e6-4402-bd47-05d8cbc99ef3@linaro.org/ > ah, yes, makes sense. I saw you had your own patch doing the reverse, I'll take yours and rebase on top.
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index 0b0db735dc8e..cfb3ddc7f885 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -393,11 +393,11 @@ hsi2c_8: i2c@10970000 { interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH 0>; #address-cells = <1>; #size-cells = <0>; - pinctrl-names = "default"; - pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; + pinctrl-0 = <&hsi2c8_bus>; + pinctrl-names = "default"; status = "disabled"; }; }; @@ -473,11 +473,11 @@ hsi2c_12: i2c@10d50000 { interrupts = <GIC_SPI 655 IRQ_TYPE_LEVEL_HIGH 0>; #address-cells = <1>; #size-cells = <0>; - pinctrl-0 = <&hsi2c12_bus>; - pinctrl-names = "default"; clocks = <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_IPCLK_5>, <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_PCLK_5>; clock-names = "hsi2c", "hsi2c_pclk"; + pinctrl-0 = <&hsi2c12_bus>; + pinctrl-names = "default"; status = "disabled"; }; };
Reverse pinctrl-* lines, first pinctrl-0 then pinctrl-names. Move the pinctrl-* properties after clocks so that we keep alphabetic order and align with the other similar definitions. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)