| Message ID | 20240430-samsung-pinctrl-busclock-dts-v2-4-14fc988139dd@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hook up pin controller clocks on Google Tensor gs101 | expand |
All 4 patches could have been squashed in a single patch as they do the
same thing, but I'm fine either way:
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
On Thu, 2024-05-02 at 07:51 +0100, Tudor Ambarus wrote: > > All 4 patches could have been squashed in a single patch as they do the > same thing, but I'm fine either way: > > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> I guess the patches had accumulated gradually over a period of time while more CMU support was being implemented. I'm happy to squash them if that's the preference? Krzysztof? Cheers, Andre'
On 02/05/2024 12:44, André Draszik wrote: > On Thu, 2024-05-02 at 07:51 +0100, Tudor Ambarus wrote: >> >> All 4 patches could have been squashed in a single patch as they do the >> same thing, but I'm fine either way: >> >> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > > I guess the patches had accumulated gradually over a period of time while > more CMU support was being implemented. > > I'm happy to squash them if that's the preference? Krzysztof? It's fine. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index f8fcbbb06e7b..c8a5eb8c7d45 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -1309,6 +1309,9 @@ usbdrd31_dwc3: usb@0 { pinctrl_hsi1: pinctrl@11840000 { compatible = "google,gs101-pinctrl"; reg = <0x11840000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; interrupts = <GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH 0>; }; @@ -1380,11 +1383,17 @@ wakeup-interrupt-controller { pinctrl_gsactrl: pinctrl@17940000 { compatible = "google,gs101-pinctrl"; reg = <0x17940000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; pinctrl_gsacore: pinctrl@17a80000 { compatible = "google,gs101-pinctrl"; reg = <0x17a80000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; cmu_top: clock-controller@1e080000 {
The pinctrl instances hsi1, gsactrl, and gsacore need a clock for register access to work. Since we haven't implemented the relevant CMUs for the clocks required by these instances just add empty clocks for now so as to make the DT pass the validation checks. Once the clocks are implmented in the gs101 clock driver, these should be updated then. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v2: use empty clock instead of placeholder --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)