diff mbox series

[2/4] drm/exynos/vidi: use drm_edid_duplicate()

Message ID 20240530100154.317683-2-jani.nikula@intel.com (mailing list archive)
State Accepted
Commit 679ca523843004bd656a712e703489e15be992c8
Headers show
Series [1/4] drm/exynos/vidi: fix memory leak in .get_modes() | expand

Commit Message

Jani Nikula May 30, 2024, 10:01 a.m. UTC 
Don't open code drm_edid_duplicate(). While at it, drop the error
message on allocation failure.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
index 11a720fef32b..f613df719a02 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
@@ -308,7 +308,6 @@  static int vidi_get_modes(struct drm_connector *connector)
 {
 	struct vidi_context *ctx = ctx_from_connector(connector);
 	struct edid *edid;
-	int edid_len;
 	int count;
 
 	/*
@@ -320,12 +319,9 @@  static int vidi_get_modes(struct drm_connector *connector)
 		return 0;
 	}
 
-	edid_len = (1 + ctx->raw_edid->extensions) * EDID_LENGTH;
-	edid = kmemdup(ctx->raw_edid, edid_len, GFP_KERNEL);
-	if (!edid) {
-		DRM_DEV_DEBUG_KMS(ctx->dev, "failed to allocate edid\n");
+	edid = drm_edid_duplicate(ctx->raw_edid);
+	if (!edid)
 		return 0;
-	}
 
 	drm_connector_update_edid_property(connector, edid);