| Message ID | 20240726110114.1509733-3-m.majewski2@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/6] drivers/thermal/exynos: use DEFINE_SIMPLE_DEV_PM_OPS | expand |
On Fri, Jul 26, 2024 at 6:01 AM Mateusz Majewski <m.majewski2@samsung.com> wrote: > > Slightly simpler and nothing is lost if _suspend and _resume functions > are built unconditionally. > > Suggested-by: Anand Moon <linux.amoon@gmail.com> > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/thermal/samsung/exynos_tmu.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 9b7ca93a72f1..b68e9755c933 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1132,7 +1132,6 @@ static void exynos_tmu_remove(struct platform_device *pdev) > clk_unprepare(data->clk_sec); > } > > -#ifdef CONFIG_PM_SLEEP > static int exynos_tmu_suspend(struct device *dev) > { > exynos_tmu_control(to_platform_device(dev), false); > @@ -1152,15 +1151,11 @@ static int exynos_tmu_resume(struct device *dev) > > static DEFINE_SIMPLE_DEV_PM_OPS(exynos_tmu_pm, > exynos_tmu_suspend, exynos_tmu_resume); > -#define EXYNOS_TMU_PM (&exynos_tmu_pm) > -#else > -#define EXYNOS_TMU_PM NULL > -#endif > > static struct platform_driver exynos_tmu_driver = { > .driver = { > .name = "exynos-tmu", > - .pm = EXYNOS_TMU_PM, > + .pm = pm_sleep_ptr(&exynos_tmu_pm), > .of_match_table = exynos_tmu_match, > }, > .probe = exynos_tmu_probe, > -- > 2.45.1 >
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 9b7ca93a72f1..b68e9755c933 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1132,7 +1132,6 @@ static void exynos_tmu_remove(struct platform_device *pdev) clk_unprepare(data->clk_sec); } -#ifdef CONFIG_PM_SLEEP static int exynos_tmu_suspend(struct device *dev) { exynos_tmu_control(to_platform_device(dev), false); @@ -1152,15 +1151,11 @@ static int exynos_tmu_resume(struct device *dev) static DEFINE_SIMPLE_DEV_PM_OPS(exynos_tmu_pm, exynos_tmu_suspend, exynos_tmu_resume); -#define EXYNOS_TMU_PM (&exynos_tmu_pm) -#else -#define EXYNOS_TMU_PM NULL -#endif static struct platform_driver exynos_tmu_driver = { .driver = { .name = "exynos-tmu", - .pm = EXYNOS_TMU_PM, + .pm = pm_sleep_ptr(&exynos_tmu_pm), .of_match_table = exynos_tmu_match, }, .probe = exynos_tmu_probe,
Slightly simpler and nothing is lost if _suspend and _resume functions are built unconditionally. Suggested-by: Anand Moon <linux.amoon@gmail.com> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)