| Message ID | 20241127-gs101-phy-lanes-orientation-phy-v1-6-1b7fce24960b@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | USB31DRD phy updates for Google Tensor gs101 (orientation & DWC3 rpm) | expand |
On 27/11/2024 11:58, André Draszik wrote: > We currently don't gate the power to the SS phy in phy_exit(). > > Shuffle the code slightly to ensure the power is gated to the SS phy as > well. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- I think this should be actually a fix with cc-stable. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On Wed, 2024-11-27 at 20:42 +0100, Krzysztof Kozlowski wrote: > On 27/11/2024 11:58, André Draszik wrote: > > We currently don't gate the power to the SS phy in phy_exit(). > > > > Shuffle the code slightly to ensure the power is gated to the SS phy as > > well. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > > I think this should be actually a fix with cc-stable. Will do in v2. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks for the review! Cheers, Andre'
Hi André, On Wed, 27 Nov 2024 at 10:58, André Draszik <andre.draszik@linaro.org> wrote: > > We currently don't gate the power to the SS phy in phy_exit(). > > Shuffle the code slightly to ensure the power is gated to the SS phy as > well. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Peter Griffin <peter.griffin@linaro.org> regards, Peter
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 2a724d362c2d..c1ce6fdeef31 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -1296,14 +1296,17 @@ static int exynos5_usbdrd_gs101_phy_exit(struct phy *phy) struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); int ret; + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + ret = exynos850_usbdrd_phy_exit(phy); + if (ret) + return ret; + } + + exynos5_usbdrd_phy_isol(inst, true); + if (inst->phy_cfg->id != EXYNOS5_DRDPHY_UTMI) return 0; - ret = exynos850_usbdrd_phy_exit(phy); - if (ret) - return ret; - - exynos5_usbdrd_phy_isol(inst, true); return regulator_bulk_disable(phy_drd->drv_data->n_regulators, phy_drd->regulators); }
We currently don't gate the power to the SS phy in phy_exit(). Shuffle the code slightly to ensure the power is gated to the SS phy as well. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)