Message ID | 20241220-gs101-acpm-dt-v3-2-642d64daa5d1@linaro.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | arm64: exynos: gs101: add ACPM related nodes | expand |
On 20/12/2024 15:45, Tudor Ambarus wrote: > GS101 has 14 mailbox controllers. Add the AP to APM mailbox node. > > Mailbox controllers have a shared register that can be used for passing > the mailbox messages. The AP to APM mailbox controller is used just as a > doorbell mechanism. It raises interrupt to the firmware after the mailbox > message has been written to SRAM where the TX/RX rings are defined. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index 1441e9a252c2..6947dd081a0e 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -1445,6 +1445,15 @@ wakeup-interrupt-controller { > }; > }; > > + ap2apm_mailbox: mailbox@17610000 { > + compatible = "google,gs101-mbox"; I don't think I have this in my tree and cover letter does not explain where I can find bindings. Nothing in next from few days ago. Always document in DTS patchset where are the bindings, unless it's obvious. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index 1441e9a252c2..6947dd081a0e 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -1445,6 +1445,15 @@ wakeup-interrupt-controller { }; }; + ap2apm_mailbox: mailbox@17610000 { + compatible = "google,gs101-mbox"; + reg = <0x17610000 0x1000>; + clocks = <&cmu_apm CLK_GOUT_APM_MAILBOX_APM_AP_PCLK>; + clock-names = "pclk"; + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH 0>; + #mbox-cells = <0>; + }; + pinctrl_gsactrl: pinctrl@17940000 { compatible = "google,gs101-pinctrl"; reg = <0x17940000 0x00001000>;
GS101 has 14 mailbox controllers. Add the AP to APM mailbox node. Mailbox controllers have a shared register that can be used for passing the mailbox messages. The AP to APM mailbox controller is used just as a doorbell mechanism. It raises interrupt to the firmware after the mailbox message has been written to SRAM where the TX/RX rings are defined. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)