diff mbox series

[v3,3/5] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible

Message ID 20250219-exynos7870-pmu-clocks-v3-3-0d1e415e9e3a@disroot.org (mailing list archive)
State New
Headers show
Series Introduce support for Exynos7870 clocks and PMU | expand

Commit Message

Kaustabh Chakraborty Feb. 18, 2025, 6:50 p.m. UTC
Document the compatible string for the Exynos7870 PMU. It's compatible
with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
as well as other system control registers (i.e registers for the USB PHY).

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 19, 2025, 8:09 a.m. UTC | #1
On Wed, Feb 19, 2025 at 12:20:30AM +0530, Kaustabh Chakraborty wrote:
> Document the compatible string for the Exynos7870 PMU. It's compatible
> with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
> as well as other system control registers (i.e registers for the USB PHY).
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>  1 file changed, 1 insertion(+)

I don't understand why did you send SoC patch to clock. I asked to split
by subsystem.

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 19, 2025, 8:18 a.m. UTC | #2
On 19/02/2025 09:09, Krzysztof Kozlowski wrote:
> On Wed, Feb 19, 2025 at 12:20:30AM +0530, Kaustabh Chakraborty wrote:
>> Document the compatible string for the Exynos7870 PMU. It's compatible
>> with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
>> as well as other system control registers (i.e registers for the USB PHY).
>>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I don't understand why did you send SoC patch to clock. I asked to split
> by subsystem.

I guess because of clkout driver. I don't want to grow the clkout OF
device ID table with compatible entries, but I also have doubts that it
is compatible and that you actually tested it.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index 8e6d051d8c97de0c843a91350a5cb9c332b2d6ce..3baee81df54981cb4c6502c1ddf5be3d5e3184c3 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -52,6 +52,7 @@  properties:
           - const: syscon
       - items:
           - enum:
+              - samsung,exynos7870-pmu
               - samsung,exynos7885-pmu
               - samsung,exynos8895-pmu
               - samsung,exynos9810-pmu