From patchwork Tue Mar 4 17:05:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001162 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB9828FFE0 for ; Tue, 4 Mar 2025 17:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; cv=none; b=IYbCX2agLgXSCnUoypaYVZoqxnCPjOrEGl+TJevq1ELv8iC2d+sdsz+MxivqSIsPCdcCf4WqBkIJ6+PU4HBg/7wmMKjpGAViSUhuEnh8g8EUMIacPBwxANnhG75bEzAycb+/SaRDnDQy7buy6jaG3Fdz7vQKZWZhSswRIw0H+Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; c=relaxed/simple; bh=w6Ez2HJK0lLtjno5cUxK05/kYeMcWHjoaFlGGgugd14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kiGt68bDo2PtU6oY52yTww+IUSNbdMJ/Lcs5iIPLoFgvtj/JfCiQPJIv+Vu+T9EA1p+ImF/FlVcsdDwEqM+dSM+3N/86e5hx1XWCPTCLGC3p1X4tZFcuV1AKs/fj/Kv+mZbCFcCGy9VYlrpB0MGDBN438sgYbaP+7Nogg2WrioQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n4wQBx0N; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n4wQBx0N" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e4b410e48bso8895127a12.0 for ; Tue, 04 Mar 2025 09:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107938; x=1741712738; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=n4wQBx0N1w5ENAaX/0C2H1OLJrJ2AZ4Sa1Y8rwOYtPRxSx3d1wWcB+1K3jeM85jw4y iKOTh3c0HII7ikEh9wkb7DcikKMjlhoLdoR1gvCLTSVDKwYFDAx06ruJ7O+s+KQW+5uV 2XVLhhVJAj4o/ZRBNdX6Z0v+jGoP/8yU2+mVnbKb6Mk0YdmHyLAR/WglgvAzp27IJaAd /0jXs2AR/Lw2KDvdkB/2wxfQ2Ib1Sy3j+K/sfLSxMZ2reJAaNft7G7BHRdOPgLCkKCP7 MB+eQybiTh5qGX1R2PMfyG+R8DskFbK51x3SnN7SuIfS+fQdRzJhVKzZcT0b7NqdWLMn SEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107938; x=1741712738; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=vJ0r+SE2RR2dG5YBHObNbVzchM2JAsF3XPtWR1KBxLKnG1hf54fDqsYfEy8o6a5zuu JeDjLgDkdag+eA+IpoyDMcB5OUwGSvpuaV9jbJzh4BAGsSS3/M8L6G3mqZt8vlXONo7u z1H/hNFCScpobTqd2d6ud7PoLvAFKkD9BDtQpBBsFEJpRkPYHEeT7g7LaBbCP5FSLQ/a ESyt2G6kQZSlDlXlki6tPoCLN5tyy2GB1UGSQ4Xg7+EP/rAwveDFrcSoM4SHQvh5ticw f0sugQm9ezowlwYKpjZvP19ICCIwwPZ2Lxv/jsyN3lptIJxZ9fFMpbrg1cAyPT0YDGQY PsEw== X-Forwarded-Encrypted: i=1; AJvYcCVDQzsutIat3y0Ce9oN0hoYGjcGdo5LU5n5WQUWUY2ZCRzMRXEsNU7VnOQht3HYoMeLTPi8I7xPgbAaea+EdfC7ew==@vger.kernel.org X-Gm-Message-State: AOJu0YwCHFnzNE1xvWaL0Ud0epMeTwSFUmqnV5JprlQtsgcDfWFJB8aa ix4bsDe2BR+o3vszoVRu8+/JYizS7PznjsW6vax/IwvxfeOlRpSO7dAIMKILgurDqW5HAcG0g0I /MNA= X-Gm-Gg: ASbGncv5GalnTe/zafX8eoaTURTkmL2EvK+kqTV22GA75Dp/E0kdt6zPB5YnX28x/KJ 8EQEBiDvqmiRbvVksg2ApX+RaYXqrXPLx1YFAujcC6xzbYeEjzs01eTY3tOH1OVatGbSZKdjVfn dEmYm0Ffg80oVuIMBdbnsMMstddj4UwbsKDMckKjPtw2zTcB2M12kPk2GRkofN9gNolodgm0gcJ l91LvA0nibX4LZzwSzdVjGSJ5ZJQIsdJ+ItVbFQmWhf/IIq92CDUAyp0aXBm0j6G57eBl2Lc5T0 UcGHQuec6whITmJ2GlOTUFyWfwzkbEIV+sZY5fFAuyxtD5SgZGlmJLPrKN7ZlFO0dt2Jm+UScBo tXgc30ypIQTpCGFptc/YUGruzR6Cq X-Google-Smtp-Source: AGHT+IHF998NpSXE/Qa2EdiSn4vtx17I0lnFV/wyKnxAJsCHaDM1j6HSEMvcUwtHdnvoXlFd/CgYog== X-Received: by 2002:a05:6402:d0b:b0:5e4:c532:d693 with SMTP id 4fb4d7f45d1cf-5e4d6b8535fmr16782448a12.31.1741107937989; Tue, 04 Mar 2025 09:05:37 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:37 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:38 +0000 Subject: [PATCH v2 10/16] rtc: pl030: drop needless struct pl030_rtc::rtc member Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-10-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: André Draszik --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; ret = amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) goto err_rtc; } - rtc->rtc = devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret = PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_rtc; } - rtc->rtc->ops = &pl030_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &pl030_ops; + rtc_dev->range_max = U32_MAX; rtc->base = ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret = -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) if (ret) goto err_irq; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto err_reg;