From patchwork Thu Apr 4 00:35:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 2389881 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DA0843FD8C for ; Thu, 4 Apr 2013 00:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761463Ab3DDAgT (ORCPT ); Wed, 3 Apr 2013 20:36:19 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:22663 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761262Ab3DDAgS convert rfc822-to-8bit (ORCPT ); Wed, 3 Apr 2013 20:36:18 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MKP00C0ZGBY2760@mailout4.samsung.com>; Thu, 04 Apr 2013 09:35:58 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 4C.B2.05174.EEACC515; Thu, 04 Apr 2013 09:35:58 +0900 (KST) X-AuditID: cbfee68f-b7f4a6d000001436-ad-515ccaee5a68 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 22.27.17838.EEACC515; Thu, 04 Apr 2013 09:35:58 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MKP004POGBY0X30@mmp2.samsung.com>; Thu, 04 Apr 2013 09:35:58 +0900 (KST) From: Kukjin Kim To: 'Alexandre Courbot' , 'Romain Naour' Cc: 'linux-next' , 'Grant Likely' , 'Linus Walleij' , tomasz.figa@gmail.com, heiko@sntech.de, linux-samsung-soc@vger.kernel.org References: <51576214.8010307@openwide.fr> In-reply-to: Subject: RE: GENERIC_GPIO considered deprecated Date: Thu, 04 Apr 2013 09:35:58 +0900 Message-id: <26e401ce30cc$602e45f0$208ad1d0$%kim@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4uXbvsamMPHd4WT2qIcayPBRr9QgCaPRHg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t8zA913p2ICDbqm6Vmce/WIxeLVmY1s Fv8fvWa16F1wlc1iyp/lTBYHF7YxWsw4v4/JYsvPDkaLVbv+MDpweuycdZfd4861PWwer66x ePRtWcXo8fOljsf2a/OYPT5vkgtgj+KySUnNySxLLdK3S+DKaP+2h7XgjmRF58O5zA2Mb0W6 GDk4JARMJC5sNu5i5AQyxSQu3FvP1sXIxSEksIxR4tuffiaIhIlEf/MCFojEdEaJV8/+MYIk hAT+MkrsOlIHYrMJaEgcfv+MHcQWEQiXuLTnMzNIA7PANUaJjb96oMbuYpRY/3UrK0gVp0Cw xJpns5lBbGEBfYmbD46A2SwCqhJzX34Bm8QrYCvxZ/suJghbUOLH5HssIGczC6hLTJmSCxJm FtCWePLuAivEN+oSj/7qQtxgJPHm5mF2iBIRiX0v3jGCnCAh0Msh8fvoOhaIVQIS3yYfYoHo lZXYdIAZ4mFJiYMrbrBMYJSYhWTxLITFs5AsnoVkwwJGllWMoqkFyQXFSelFxnrFibnFpXnp esn5uZsYIfHdv4Px7gHrQ4zJQNsnMkuJJucD00NeSbyhsZmRhamJqbGRuaUZacJK4rxqLdaB QgLpiSWp2ampBalF8UWlOanFhxiZODilGhi9lt247Nh+hp15ymu2n9M6F02ZkTLl7083rTc/ 7pzcduD0g+WbtNdv+ibxQHRhW/VO57ytxh+efF/OMcnoatNVRTG7klmTp2lqq2kyu8vPvlt1 Z3aIs7ea1WbrvKpkyZdzDuQqvbU/bLvx04ENrRfmT1VZGJlYcb4x5uPKk3uk+0+Zvak6JPwi U4mlOCPRUIu5qDgRAJjcKr8FAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAKsWRmVeSWpSXmKPExsVy+t9jQd13p2ICDbq/a1ice/WIxeLVmY1s Fv8fvWa16F1wlc1iyp/lTBYHF7YxWsw4v4/JYsvPDkaLVbv+MDpweuycdZfd4861PWwer66x ePRtWcXo8fOljsf2a/OYPT5vkgtgj2pgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0 tDBXUshLzE21VXLxCdB1y8wBukxJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEa SFjHmNH+bQ9rwR3Jis6Hc5kbGN+KdDFyckgImEj0Ny9ggbDFJC7cW8/WxcjFISQwnVHi1bN/ jCAJIYG/jBK7jtSB2GwCGhKH3z9jB7FFBMIlLu35zAzSwCxwjVFi468eqO5djBLrv25lBani FAiWWPNsNjOILSygL3HzwREwm0VAVWLuyy9gk3gFbCX+bN/FBGELSvyYfA/oJA6gqeoSU6bk goSZBbQlnry7wAoSlgAKP/qrC3GDkcSbm4fZIUpEJPa9eMc4gVFoFpJBsxAGzUIyaBaSjgWM LKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgtPHM6kdjCsbLA4xCnAwKvHwrvSPCRRiTSwr rsw9xCjBwawkwrthJVCINyWxsiq1KD++qDQntfgQYzLQmxOZpUST84GpLa8k3tDYxMzI0sjM wsjE3Jw0YSVx3gOt1oFCAumJJanZqakFqUUwW5g4OKUaGI9tad92s7yebaLsss9nhftnsnx+ 1h6s0BZQxyDCP89R/uRkpYlFp09YTLta1nh8xzat/2x1r4wPh11cNHGeyM+jMhVvLlyR2eDA /jvhdLdqvugBtvsle7h2cnvu+zdFrL/W9PBcX/d+xdn61/0/GO/eo8d6K69Zqcjl1rSSwEV8 Bfv2W+/7FKbEUpyRaKjFXFScCABO6boEYwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Alexandre Courbot wrote: > > Hi Romain, > > On Sat, Mar 30, 2013 at 3:07 PM, Romain Naour > wrote: > > Hi Alex, > > > > When I read your mail, I was surprised that you were speaking about > GPIOs, my pathes for samsung CPUs are intended for timer sub-system. > > > > As you can see in this thread, when I send my patches "ARM: S3C24XX: Add > samsung-time support for s3c24xx" and "Add samsung-time support for > s5pc100". They didn't add "select GENERIC_GPIO". > > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13432/focus=14980 > > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13432/focus=14982 > > > > There is something wrong with the commit, I see that "select > GENERIC_GPIO" was added in my patches by mistake. Oops, sorry about that. > > > > I recommend you to speak directly with samsung's kernel maintainer that > I CC in this mail. > Thanks... > Indeed, it seems like these "select GENERIC_GPIO" have been added > during the merge of your patches, since I can see the line is here in > your patch (but not added by it). Kim, on the current next there are > two of these "select GENERIC_GPIO" that are added from your branch, OK, I see. > could you amend the patches that adds them such as they get changed > into "select ARCH_REQUIRE_GPIOLIB" instead? You can grep for "select I can do it for my tree but the branch already included in arm-soc tree so I think, it should be fixed with another patch. And > GENERIC_GPIO" in arch/arm to find the offending lines. We are removing > GENERIC_GPIO and this work cannot be merged until you do this since it > would break ARM builds. Thanks! > So how about following? If you are OK, let me take into samsung tree. --------8<----------------8<-------- From: Kukjin Kim Subject: [PATCH] ARM: SAMSUNG: change GENERIC_GPIO to ARCH_REQUIRE_GPIOLIB When I applied regarding samsung-time patches, the "select GENERIC_GPIO" has been added wrong, so this patch fixes that. And since the GENERIC_GPIO in arch/arm/ will be gone away, this adds ARCH_REQUIRE_GPIOLIB for S3C24XX and S5PC100 instead. Reported-by: Alexandre Courbot Cc: Romain Naour Signed-off-by: Kukjin Kim --- arch/arm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 46fcfa8..a239c7e 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -770,10 +770,10 @@ config ARCH_SA1100 config ARCH_S3C24XX bool "Samsung S3C24XX SoCs" select ARCH_HAS_CPUFREQ + select ARCH_REQUIRE_GPIOLIB select CLKDEV_LOOKUP select CLKSRC_MMIO select GENERIC_CLOCKEVENTS - select GENERIC_GPIO select HAVE_CLK select HAVE_S3C2410_I2C if I2C select HAVE_S3C2410_WATCHDOG if WATCHDOG @@ -828,11 +828,11 @@ config ARCH_S5P64X0 config ARCH_S5PC100 bool "Samsung S5PC100" + select ARCH_REQUIRE_GPIOLIB select CLKDEV_LOOKUP select CLKSRC_MMIO select CPU_V7 select GENERIC_CLOCKEVENTS - select GENERIC_GPIO select HAVE_CLK select HAVE_S3C2410_I2C if I2C select HAVE_S3C2410_WATCHDOG if WATCHDOG