From patchwork Tue Mar 26 06:54:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 2335041 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 56A553FC54 for ; Tue, 26 Mar 2013 06:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757160Ab3CZGzN (ORCPT ); Tue, 26 Mar 2013 02:55:13 -0400 Received: from intranet.asianux.com ([58.214.24.6]:22292 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753695Ab3CZGzN (ORCPT ); Tue, 26 Mar 2013 02:55:13 -0400 Received: by intranet.asianux.com (Postfix, from userid 103) id C418D1840342; Tue, 26 Mar 2013 14:55:09 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 5B0CD1840236; Tue, 26 Mar 2013 14:55:09 +0800 (CST) Message-ID: <51514630.6090906@asianux.com> Date: Tue, 26 Mar 2013 14:54:40 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: ben-linux@fluff.org, "kgene.kim@samsung.com" CC: Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org >> \"linux-samsung-soc@vger.kernel.org\"" Subject: [PATCH] ARM:s3c24xx: beautify code, data->hwirq is unsigned long which is always >= 0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org data->hwirq is unsigned long which is always >= 0 Signed-off-by: Chen Gang --- arch/arm/mach-s3c24xx/irq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c24xx/irq.c b/arch/arm/mach-s3c24xx/irq.c index 5c9f8b7..143f57b 100644 --- a/arch/arm/mach-s3c24xx/irq.c +++ b/arch/arm/mach-s3c24xx/irq.c @@ -210,7 +210,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type) void __iomem *gpcon_reg; unsigned long gpcon_offset, extint_offset; - if ((data->hwirq >= 0) && (data->hwirq <= 3)) { + if (data->hwirq <= 3) { gpcon_reg = S3C2410_GPFCON; extint_reg = S3C24XX_EXTINT0; gpcon_offset = (data->hwirq) * 2;