From patchwork Thu Jun 26 16:08:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 4428361 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A47D2BEEAA for ; Thu, 26 Jun 2014 16:08:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 93CE420179 for ; Thu, 26 Jun 2014 16:08:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F207E201DC for ; Thu, 26 Jun 2014 16:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbaFZQIV (ORCPT ); Thu, 26 Jun 2014 12:08:21 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:65020 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbaFZQIU (ORCPT ); Thu, 26 Jun 2014 12:08:20 -0400 Received: by mail-pb0-f54.google.com with SMTP id un15so3356986pbc.27 for ; Thu, 26 Jun 2014 09:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=w22xCs97yMetf3ZY5w0TjjT77vk5CeAmBWeXweSkR78=; b=O9v7qUm32Xik91DJEmnRCSWRAfruI3j9KmwYIyx6HRk+amV0ElSZIj9FvDkxE+kkop d/1GxLI3J5I6kgly27Gs1jtdeK9NqKMOZzi1iXGb6S6ZTG8/tnL56SUuVOZKw+PNR41F pcr0Ck4PFAGGd5uKs0IZiiT6asvSaCp3Sz30MtRxWLyTrMnV2fCdBqTTtCLTFMUNm1U6 RbMq1uDsX8zhDC5SpNmG1p+CbWACat3efwQ4DQCeDtIC8Lf3MKQd389Smzi9AoleRmub c2rnzAuw6CG68ylo/uGdgXqBI3S3aEmObk62XCBIJCI7B1MV9JQ3pMVjNy83xMNBpKYo j01g== X-Gm-Message-State: ALoCoQkFDWuhw+6hFeRAbLbq++cjDfXWWrDvBJSttooQ9yMgij2mFqBcVvTTWP4kF4qbuzcDBcJs X-Received: by 10.66.161.69 with SMTP id xq5mr22789588pab.62.1403798899579; Thu, 26 Jun 2014 09:08:19 -0700 (PDT) Received: from localhost (c-67-183-17-239.hsd1.wa.comcast.net. [67.183.17.239]) by mx.google.com with ESMTPSA id tg9sm10722427pbc.29.2014.06.26.09.08.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 26 Jun 2014 09:08:18 -0700 (PDT) From: Kevin Hilman To: Tushar Behera Cc: Doug Anderson , Kukjin Kim , Kukjin Kim , "linux-kernel\@vger.kernel.org" , "devicetree\@vger.kernel.org" , linux-samsung-soc , "linux-arm-kernel\@lists.infradead.org" , Mike Turquette , Tomasz Figa , Russell King , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Shaik Ameer Basha Subject: Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420 References: <1402464739-19044-1-git-send-email-tushar.b@samsung.com> <1402464739-19044-3-git-send-email-tushar.b@samsung.com> <7hpphwlgn0.fsf@paris.lan> Date: Thu, 26 Jun 2014 09:08:17 -0700 In-Reply-To: (Tushar Behera's message of "Thu, 26 Jun 2014 08:50:50 +0530") Message-ID: <7h8uojk61a.fsf@paris.lan> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tushar Behera writes: > On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote: >> Doug Anderson writes: >> >>> Tushar, >>> >>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >>>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>>> As per the user manual, it should be CLK_MAU_EPLL. >>>> >>>> The problem surfaced when the bootloader in Peach-pit board set >>>> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >>>> we used to get a system hang during late boot if CLK_MAU_EPLL was >>>> disabled. >>>> >>>> Signed-off-by: Tushar Behera >>>> Signed-off-by: Shaik Ameer Basha >>>> Reported-by: Kevin Hilman >>>> --- >>>> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> I've tested this myself now as well. >>> >>> Tested-by: Doug Anderson >> >> For me, this patch alone (on top of -next) doesn't solve the boot hang. >> I still need clk_ignore_unused for a successful boot. >> >> So, this patch might be correct, but it doesn't prevent a boot hang >> using a chain-loaded nv_uboot on peach-pi. There's still another clock >> being disabled that causes a hang. >> >> Kevin > > Kevin, > > Can you please check if adding patch 1/3 alongwith patch 2/3 fixes the > issue for you? Yes, using patch 1/3 along with 2/3 fixes the issue. > Also can you please confirm that setting CLK_IGNORE_UNUSED flag > CLK_MAU_EPLL alone fixes the issue, without any need for > clk_ignore_unused in u-boot bootargs? Yes, I have this patch[1] in my local branch which fixes the issue alone, without clk_ignore_unused on the command line. Kevin [1] From ab1627127730ef4507ce96cbf95047d626bbb53f Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Thu, 5 Jun 2014 17:12:28 -0700 Subject: [PATCH] KJH: leave mau_epll enabled --- drivers/clk/samsung/clk-exynos5420.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 61eccf0dd72f..ed175088ee7e 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[] __initdata = { SRC_MASK_TOP2, 24, 0, 0), GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk", - SRC_MASK_TOP7, 20, 0, 0), + SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0), /* sclk */ GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0",