| Message ID | 860eb8a1eed879e55daf960c96acdac514cbda93.1596028601.git.guillaume.tucker@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] ARM: exynos: clear L220_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val | expand |
On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: > The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable > sequence. There is no need to set it in the default register value, > this was done before support for it was implemented in the code. It > is not set in the hardware initial value either. > > Clean this up by removing this flag from the default l2c_aux_val, and > add it to the l2c_aux_mask to print an alert message if it was already > set before the kernel initialisation. > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> > --- > arch/arm/mach-exynos/exynos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Makes sense. I'll take it after the merge window. Best regards, Krzysztof
On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: > > The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable > > sequence. There is no need to set it in the default register value, > > this was done before support for it was implemented in the code. It > > is not set in the hardware initial value either. > > > > Clean this up by removing this flag from the default l2c_aux_val, and > > add it to the l2c_aux_mask to print an alert message if it was already > > set before the kernel initialisation. > > > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> > > --- > > arch/arm/mach-exynos/exynos.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Makes sense. I'll take it after the merge window. Yes, because platforms actually have no control over this bit through these values. Please fix the description to use the right define, it's L310_AUX_CTRL_NS_LOCKDOWN not L220_AUX_CTRL_NS_LOCKDOWN.
On 03/08/2020 15:22, Russell King - ARM Linux admin wrote: > On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: >> On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: >>> The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable >>> sequence. There is no need to set it in the default register value, >>> this was done before support for it was implemented in the code. It >>> is not set in the hardware initial value either. >>> >>> Clean this up by removing this flag from the default l2c_aux_val, and >>> add it to the l2c_aux_mask to print an alert message if it was already >>> set before the kernel initialisation. >>> >>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> >>> --- >>> arch/arm/mach-exynos/exynos.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Makes sense. I'll take it after the merge window. > > Yes, because platforms actually have no control over this bit through > these values. > > Please fix the description to use the right define, it's > L310_AUX_CTRL_NS_LOCKDOWN not L220_AUX_CTRL_NS_LOCKDOWN. Thanks, fixed in v2. Guilaume
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 36c37444485a..a96f3353a0c1 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void) } DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)") - .l2c_aux_val = 0x3c400000, - .l2c_aux_mask = 0xc20fffff, + .l2c_aux_val = 0x38400000, + .l2c_aux_mask = 0xc60fffff, .smp = smp_ops(exynos_smp_ops), .map_io = exynos_init_io, .init_early = exynos_firmware_init,
The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable sequence. There is no need to set it in the default register value, this was done before support for it was implemented in the code. It is not set in the hardware initial value either. Clean this up by removing this flag from the default l2c_aux_val, and add it to the l2c_aux_mask to print an alert message if it was already set before the kernel initialisation. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> --- arch/arm/mach-exynos/exynos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)