From patchwork Thu Jun 19 03:54:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 4380561 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 92F2DBEEAA for ; Thu, 19 Jun 2014 03:54:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 85D2F20384 for ; Thu, 19 Jun 2014 03:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99A9320382 for ; Thu, 19 Jun 2014 03:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756663AbaFSDyJ (ORCPT ); Wed, 18 Jun 2014 23:54:09 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:34603 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbaFSDyI (ORCPT ); Wed, 18 Jun 2014 23:54:08 -0400 Received: by mail-lb0-f178.google.com with SMTP id 10so1099254lbg.9 for ; Wed, 18 Jun 2014 20:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VB3wt8/N2AvqbiE3OJIo7IGqN0QbpKdvmTSyiloqEbI=; b=Wu6h+GnymrmBfMKAdcst9PzzV0bR6P2lGP9WQ/xfHlYk/HAb0oCRMJYIgh6qr7lqFm SvOymNV5XTcCRJLblTPzYIm9lQxyK4fWe1Pf8vRYpqQgJYahbIrkm6efIJDuMGIHB9m6 llZXHGdr1tU6vGa21plVsIfr9Jh3NZaXsUQDAX2qkfxiTZNgQf3Oc9vd7/TVerUhfVXb U4srVzNWSXz9H2wSYJs4D/Zs0QdOOQ+M6mBdiBIHTno9mPMl6ym8aHhbB8hcIPptD+43 7NdPL8kz26uQjH/J46WBKRlyIK7bqJcgMWGgLNtrGw3LqTJXvh2ItUfXIj46LDFZa5PF QoMg== MIME-Version: 1.0 X-Received: by 10.112.63.162 with SMTP id h2mr1392335lbs.45.1403150045046; Wed, 18 Jun 2014 20:54:05 -0700 (PDT) Received: by 10.152.127.69 with HTTP; Wed, 18 Jun 2014 20:54:04 -0700 (PDT) In-Reply-To: References: Date: Thu, 19 Jun 2014 09:24:04 +0530 Message-ID: Subject: Re: MMC error on Exynos4210 board From: Sachin Kamat To: Tim Kryger Cc: Markus Mayer , Matt Porter , Ulf Hansson , linux-mmc , linux-samsung-soc Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jun 18, 2014 at 7:41 PM, Tim Kryger wrote: > On Wed, Jun 18, 2014 at 4:33 AM, Sachin Kamat wrote: >> Hi Tim, >> >> I see the below error on Exynos4210 based Origen board with linux-next >> (20140618). >> Reverting the below commit works fine. >> >> Commit: 8d02e775a6 "mmc: sdhci: Use mmc core regulator infrastucture" >> >> Any ideas? >> >> *************** >> >> -- [ 2.068992] sdhci: Secure Digital Host Controller Interface driver >> [ 2.075059] sdhci: Copyright(c) Pierre Ossman >> [ 2.079762] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12510000[0]' >> [ 2.088021] s3c-sdhci 12510000.sdhci: clock source 2: mmc_busclk.2 >> (50000000 Hz) >> [ 2.095322] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12510000[0]' >> [ 2.103794] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12510000[0]' >> [ 2.112478] s3c-sdhci 12510000.sdhci: No vqmmc regulator found >> [ 2.118117] mmc0: Hardware doesn't report any support voltages. >> [ 2.124004] s3c-sdhci 12510000.sdhci: sdhci_add_host() failed >> [ 2.130080] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12530000[0]' >> [ 2.138352] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 >> (16666667 Hz) >> [ 2.145661] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12530000[0]' >> [ 2.154139] of_get_named_gpiod_flags: can't parse gpios property of >> node '/sdhci@12530000[0]' >> [ 2.162834] s3c-sdhci 12530000.sdhci: No vqmmc regulator found >> [ 2.168464] mmc0: Hardware doesn't report any support voltages. >> [ 2.174349] s3c-sdhci 12530000.sdhci: sdhci_add_host() failed >> [ 2.180281] Synopsys Designware Multimedia Card Interface Driver >> [ 2.188131] usbcore: registered new interface driver usbhid >> [ 2.192287] usbhid: USB HID core driver >> [ 2.196329] TCP: cubic registered >> [ 2.199362] NET: Registered protocol family 17 >> [ 2.203917] NET: Registered protocol family 15 >> [ 2.208404] Registering SWP/SWPB emulation handler >> [ 2.214357] of_get_named_gpiod_flags exited with status 0 >> [ 2.218430] of_get_named_gpiod_flags exited with status 0 >> [ 2.223803] of_get_named_gpiod_flags exited with status 0 >> [ 2.229170] of_get_named_gpiod_flags exited with status 0 >> [ 2.234560] of_get_named_gpiod_flags exited with status 0 >> [ 2.239953] gpio-229: gpiod_set_debounce: missing set() or >> set_debounce() operations >> [ 2.247773] gpio-230: gpiod_set_debounce: missing set() or >> set_debounce() operations >> [ 2.255473] gpio-228: gpiod_set_debounce: missing set() or >> set_debounce() operations >> [ 2.263221] gpio-227: gpiod_set_debounce: missing set() or >> set_debounce() operations >> [ 2.270918] gpio-226: gpiod_set_debounce: missing set() or >> set_debounce() operations >> [ 2.278899] input: gpio_keys as /devices/gpio_keys/input/input0 >> [ 2.285196] s3c-rtc 10070000.rtc: setting system clock to >> 2000-01-01 00:00:00 UTC (946684800) >> [ 2.295072] VDD_G3D_1.1V: disabling >> [ 2.304744] VADC_3.3V: disabling >> [ 2.312095] VDD_AUD_1.8V: disabling >> [ 2.319714] VMIPI_1.1V: disabling >> [ 2.327193] VDD_ABB_3.3V: disabling >> [ 2.332779] VMEM_VDD_2.8V: disabling >> [ 2.336148] Waiting for root device /dev/mmcblk0p1... >> >> ************* >> Regards, >> Sachin. > > Would you mind reverting just this part of the commit to see if it > clears up your trouble? > >> if (host->ocr_mask) >> - ocr_avail = host->ocr_mask; >> + ocr_avail &= host->ocr_mask; Reverting this did not help. I still get the above error. My diff: FYI, the board has a 2.8V fixed regulator supply connected to the MMC. You may refer to arch/arm/boot/dts/exynos4210-origen.dts for more details. diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index c23a87285a95..f4135094320d 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -3096,7 +3096,7 @@ int sdhci_add_host(struct sdhci_host *host) ocr_avail &= mmc->ocr_avail; if (host->ocr_mask) - ocr_avail &= host->ocr_mask; + ocr_avail = host->ocr_mask; mmc->ocr_avail = ocr_avail; mmc->ocr_avail_sdio = ocr_avail;