usb phy reset for ethernet.

Commit Message

Anand Moon Sept. 10, 2016, 10:23 a.m. UTC

Hi Krzysztof,

For log time I am trying to understanding the reset for PHY for Odroid XU4
for ethenet/emmc/sdcard.

So in-order to reset the PHY I would like to attempt some thing like this below.
I am trying to understand and modify the driver drivers/regulator/s2mps11.c
If you thing this approach is good enough. Or their will be another approach.


Or is there reset core logic for the usb phy to be integrated for
exynos platform.

Please let me know your thought on this.

Best Regards
-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Krzysztof Kozlowski Sept. 16, 2016, 8:55 a.m. UTC | #1

On 09/10/2016 12:23 PM, Anand Moon wrote:
> Hi Krzysztof,
> 
> For log time I am trying to understanding the reset for PHY for Odroid XU4
> for ethenet/emmc/sdcard.
> 
> So in-order to reset the PHY I would like to attempt some thing like this below.
> I am trying to understand and modify the driver drivers/regulator/s2mps11.c
> If you thing this approach is good enough. Or their will be another approach.
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index d562530..bed5263 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -369,9 +369,10 @@
>                         };
> 
>                         ldo17_reg: LDO17 {
> -                               regulator-name = "tsp_avdd";
> +                               regulator-name = "vdd_eth";
>                                 regulator-min-microvolt = <3300000>;
>                                 regulator-max-microvolt = <3300000>;
> +                               samsung,ext-control-gpios = <&gpg1 1
> GPIO_ACTIVE_HIGH>;
>                                 regulator-always-on;
>                         };
> 
> Or is there reset core logic for the usb phy to be integrated for
> exynos platform.
> 
> Please let me know your thought on this.

I don't see any correlation between the patch and the goal you
mentioned. An always on regulator, won't be turned off... because it is
always on.

The DTS change above does not introduce any reset-phy logic. You need to
use a proper driver for that.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index d562530..bed5263 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -369,9 +369,10 @@ 
                        };

                        ldo17_reg: LDO17 {
-                               regulator-name = "tsp_avdd";
+                               regulator-name = "vdd_eth";
                                regulator-min-microvolt = <3300000>;
                                regulator-max-microvolt = <3300000>;
+                               samsung,ext-control-gpios = <&gpg1 1
GPIO_ACTIVE_HIGH>;
                                regulator-always-on;
                        };