From patchwork Tue May 7 11:48:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2532851 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E78FBDF215 for ; Tue, 7 May 2013 11:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756760Ab3EGLsY (ORCPT ); Tue, 7 May 2013 07:48:24 -0400 Received: from mail-bk0-f54.google.com ([209.85.214.54]:41722 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756225Ab3EGLsX (ORCPT ); Tue, 7 May 2013 07:48:23 -0400 Received: by mail-bk0-f54.google.com with SMTP id y8so234322bkt.41 for ; Tue, 07 May 2013 04:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=juB1baYIggU/T4ez06q2yrU6Sm5+FZuMoceyJ8LhKAk=; b=Mp+48puk4eFc3EIDvMveSPZzCU6zJ/WE1CLotGAjb0D8jHaT76+NGBhivCacRCDPUw FZL3hDeLtT68ic90As7RmLg9uHPmgZ618dnDtGG51SAmOga2kY9v4K5+UKtQDNIKwUSk /Y+F+I3C2juqtBfLA9Zam+/aawGH0Ep0eywni3vNfCS0GRcaJ4Xc31ZFqb/ZI5haYzwh aEVf4nxrboXb8RLm5bPSdjMJvCt0Rn5hKCes/VSbABxYY7SygzrDSRNDMum4iBh8HvGa EhYukQHRpSfRjrvVvx6fypAVSRm9SEHWpFDHtlTk66gvbjWv94cYyDLpCU9V1Wjo8N4L ZnEg== MIME-Version: 1.0 X-Received: by 10.205.38.3 with SMTP id tg3mr463512bkb.66.1367927302218; Tue, 07 May 2013 04:48:22 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Tue, 7 May 2013 04:48:22 -0700 (PDT) Date: Tue, 7 May 2013 19:48:22 +0800 Message-ID: Subject: [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe() From: Wei Yongjun To: ben-linux@fluff.org, kgene.kim@samsung.com, balbi@ti.com, gregkh@linuxfoundation.org Cc: yongjun_wei@trendmicro.com.cn, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org From: Wei Yongjun Fix to return a negative error code in the gpio_to_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Jingoo Han --- drivers/usb/gadget/s3c2410_udc.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index d0e75e1..c974776 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -1851,6 +1851,7 @@ static int s3c2410_udc_probe(struct platform_device *pdev) irq = gpio_to_irq(udc_info->vbus_pin); if (irq < 0) { dev_err(dev, "no irq for gpio vbus pin\n"); + retval = irq; goto err_gpio_claim; }