| Message ID | Y1wHwEm15/K87tdq@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 80194a13240b39842d46bf639c7d765ad0cb5648 |
| Headers | show |
| Series | ARM: s3c64xx: include header defining input event codes | expand |
On 28/10/2022 12:48, Dmitry Torokhov wrote: > The board file for Wolfson Cragganmore 6410 uses various KEY_* defines, > but does not include the relevant header directly and instead relies on > other headers to include it indirectly. With the upcoming cleanup of > matrix_keypad.h this indirection is now broken and we should include the > relevant header directly. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > > If possible I'd like to get this through input tree so I can take > another stab at landing matrix_keypad.h patch. > Should be fine, although there is a risk of potential conflict with Arnd's patches if he changes something more in v2. v1 was non-conflicting, at first glance. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/arch/arm/mach-s3c/mach-crag6410.c b/arch/arm/mach-s3c/mach-crag6410.c index 9a45474d1bf7..2ecb85856e24 100644 --- a/arch/arm/mach-s3c/mach-crag6410.c +++ b/arch/arm/mach-s3c/mach-crag6410.c @@ -14,6 +14,7 @@ #include <linux/fb.h> #include <linux/io.h> #include <linux/init.h> +#include <linux/input-event-codes.h> #include <linux/gpio.h> #include <linux/gpio/machine.h> #include <linux/leds.h>
The board file for Wolfson Cragganmore 6410 uses various KEY_* defines, but does not include the relevant header directly and instead relies on other headers to include it indirectly. With the upcoming cleanup of matrix_keypad.h this indirection is now broken and we should include the relevant header directly. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- If possible I'd like to get this through input tree so I can take another stab at landing matrix_keypad.h patch. arch/arm/mach-s3c/mach-crag6410.c | 1 + 1 file changed, 1 insertion(+)